<p><a href="https://review.coreboot.org/c/coreboot/+/30317">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30317/1/util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch">File util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30317/1/util/crossgcc/patches/compiler-rt-6.0.0.src_ustat.h.patch@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace">-  unsigned struct_ustat_sz = sizeof(struct ustat);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Well I would say it depends. If there is a SANITIZER_LINUX that doesn't […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The only user of struct_ustat_sz is within that block in the .inc file: struct_ustat_sz is in use if SANITIZER_LINUX and SANITIZER_ANDROID are both disabled (see line 12) and if SANITIZER_LINUX is enabled (line 45). That is, it's never used and the ustat block in the .inc file could be removed entirely.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd keep the original patch though.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30317">change 30317</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30317"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I97d3d375962b22e124583b999080305628237fd5 </div>
<div style="display:none"> Gerrit-Change-Number: 30317 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 19 Dec 2018 20:33:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>