<p><a href="https://review.coreboot.org/c/coreboot/+/30292">View Change</a></p><p>76 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30292/1/spike.dts">File spike.dts:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@16">Patch Set #1, Line 16:</a> <code style="font-family:monospace,monospace"> compatible = "ucbbar,spike-bare-dev";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace"> model = "ucbbar,spike-bare";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace"> cpus {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace"> #address-cells = <0x00000001>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace"> #size-cells = <0x00000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@21">Patch Set #1, Line 21:</a> <code style="font-family:monospace,monospace"> timebase-frequency = <10000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@21">Patch Set #1, Line 21:</a> <code style="font-family:monospace,monospace"> timebase-frequency = <10000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace"> cpu@0 {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace"> cpu@0 {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@23">Patch Set #1, Line 23:</a> <code style="font-family:monospace,monospace"> device_type = "cpu";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@23">Patch Set #1, Line 23:</a> <code style="font-family:monospace,monospace"> device_type = "cpu";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@24">Patch Set #1, Line 24:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@24">Patch Set #1, Line 24:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@25">Patch Set #1, Line 25:</a> <code style="font-family:monospace,monospace"> status = "okay";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@25">Patch Set #1, Line 25:</a> <code style="font-family:monospace,monospace"> status = "okay";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@26">Patch Set #1, Line 26:</a> <code style="font-family:monospace,monospace"> compatible = "riscv";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@26">Patch Set #1, Line 26:</a> <code style="font-family:monospace,monospace"> compatible = "riscv";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace"> riscv,isa = "rv64imafdc";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace"> riscv,isa = "rv64imafdc";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@28">Patch Set #1, Line 28:</a> <code style="font-family:monospace,monospace"> mmu-type = "riscv,sv48";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@28">Patch Set #1, Line 28:</a> <code style="font-family:monospace,monospace"> mmu-type = "riscv,sv48";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@29">Patch Set #1, Line 29:</a> <code style="font-family:monospace,monospace"> clock-frequency = <1000000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@29">Patch Set #1, Line 29:</a> <code style="font-family:monospace,monospace"> clock-frequency = <1000000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace"> interrupt-controller {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace"> interrupt-controller {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@31">Patch Set #1, Line 31:</a> <code style="font-family:monospace,monospace"> #interrupt-cells = <0x00000001>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace"> interrupt-controller;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace"> interrupt-controller;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@33">Patch Set #1, Line 33:</a> <code style="font-family:monospace,monospace"> compatible = "riscv,cpu-intc";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@33">Patch Set #1, Line 33:</a> <code style="font-family:monospace,monospace"> compatible = "riscv,cpu-intc";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@34">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace"> linux,phandle = <0x00000001>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@34">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace"> linux,phandle = <0x00000001>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@35">Patch Set #1, Line 35:</a> <code style="font-family:monospace,monospace"> phandle = <0x00000001>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@35">Patch Set #1, Line 35:</a> <code style="font-family:monospace,monospace"> phandle = <0x00000001>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@38">Patch Set #1, Line 38:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@39">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace"> memory@80000000 {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace"> device_type = "memory";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace"> device_type = "memory";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000 0x80000000 0x00000000 0x40000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000 0x80000000 0x00000000 0x40000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@42">Patch Set #1, Line 42:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace"> soc {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@44">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace"> #address-cells = <0x00000002>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"> #size-cells = <0x00000002>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@46">Patch Set #1, Line 46:</a> <code style="font-family:monospace,monospace"> compatible = "ucbbar,spike-bare-soc", "simple-bus";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@46">Patch Set #1, Line 46:</a> <code style="font-family:monospace,monospace"> compatible = "ucbbar,spike-bare-soc", "simple-bus";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@47">Patch Set #1, Line 47:</a> <code style="font-family:monospace,monospace"> ranges;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@47">Patch Set #1, Line 47:</a> <code style="font-family:monospace,monospace"> ranges;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@48">Patch Set #1, Line 48:</a> <code style="font-family:monospace,monospace"> clint@2000000 {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@48">Patch Set #1, Line 48:</a> <code style="font-family:monospace,monospace"> clint@2000000 {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@49">Patch Set #1, Line 49:</a> <code style="font-family:monospace,monospace"> compatible = "riscv,clint0";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@49">Patch Set #1, Line 49:</a> <code style="font-family:monospace,monospace"> compatible = "riscv,clint0";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@50">Patch Set #1, Line 50:</a> <code style="font-family:monospace,monospace"> interrupts-extended = <0x00000001 0x00000003 0x00000001 0x00000007>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@50">Patch Set #1, Line 50:</a> <code style="font-family:monospace,monospace"> interrupts-extended = <0x00000001 0x00000003 0x00000001 0x00000007>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@51">Patch Set #1, Line 51:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000 0x02000000 0x00000000 0x000c0000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@51">Patch Set #1, Line 51:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000 0x02000000 0x00000000 0x000c0000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@52">Patch Set #1, Line 52:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@52">Patch Set #1, Line 52:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace"> uart@2100000 {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace"> uart@2100000 {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@54">Patch Set #1, Line 54:</a> <code style="font-family:monospace,monospace"> compatible = "serial";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@54">Patch Set #1, Line 54:</a> <code style="font-family:monospace,monospace"> compatible = "serial";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@55">Patch Set #1, Line 55:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000 0x02100000 0x00000000 0x00000008>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@55">Patch Set #1, Line 55:</a> <code style="font-family:monospace,monospace"> reg = <0x00000000 0x02100000 0x00000000 0x00000008>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@56">Patch Set #1, Line 56:</a> <code style="font-family:monospace,monospace"> reg-shift = <0x00000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@56">Patch Set #1, Line 56:</a> <code style="font-family:monospace,monospace"> reg-shift = <0x00000000>;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/spike.dts@58">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace"> };</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30292/1/src/arch/riscv/boot.c">File src/arch/riscv/boot.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/src/arch/riscv/boot.c@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"> * FIXME: This is wrong and will crash. Linux can't (in early</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/src/arch/riscv/boot.c@46">Patch Set #1, Line 46:</a> <code style="font-family:monospace,monospace"> * boot) access memory that's before its own loading address.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30292/1/src/arch/riscv/boot.c@47">Patch Set #1, Line 47:</a> <code style="font-family:monospace,monospace"> * We need to copy the FDT to a place where Linux can access it.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30292">change 30292</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30292"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5ebc6cc2cc9e328f36d70fba13555386bb8c29d6 </div>
<div style="display:none"> Gerrit-Change-Number: 30292 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> </div>
<div style="display:none"> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 14:23:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>