<p><a href="https://review.coreboot.org/c/coreboot/+/30295">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30295/3/src/drivers/i2c/tpm/cr50.c">File src/drivers/i2c/tpm/cr50.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30295/3/src/drivers/i2c/tpm/cr50.c@508">Patch Set #3, Line 508:</a> <code style="font-family:monospace,monospace">     if (cr50_i2c_probe(chip, &did_vid))</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Should this be done in the "process_reset()" call below?  From the comment on that function, it look […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The call to cr50_i2c_probe() is currently unconditional, while process_reset() is conditional on verstage and bootblock.  Since this new code is now responsible for reading the DID_VID info for the debug output, it should remain where it is to maintain existing functionality. The original bug was hit in verstage, but for calls made outside of verstate/bootblock, it should have the same number I2C reads as the prior code.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30295">change 30295</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30295"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I47c59a32378ad00336277e111e81ba8d2d63e69a </div>
<div style="display:none"> Gerrit-Change-Number: 30295 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Edward Hill <ecgh@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Edward Hill <ecgh@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Keith Short <keithshort@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Bendebury <vbendeb@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 23:41:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>