<p>Edward Hill <strong>uploaded patch set #3</strong> to this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30295">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cr50: Add probe command to poll Cr50 until DID VID is valid<br><br>Added new routine cr50_i2c_probe() which ensures that communication<br>with the Cr50 over I2C is good prior to attempting other initialization<br>of the Cr50 and TPM state.  This avoids a race condition when the Cr50<br>is first booting that it may reset it's I2C slave interface during the<br>first few I2C transactions initiated from coreboot.<br><br>BUG=b:120009037<br>BRANCH=none<br>TEST=Run the Cr50 factory update against Careena board.  Confirm that<br>I2C reads are retried until the DID VID is valid.  Tested against debug<br>Cr50 firmware that forced failure of cr50_i2c_probe() and verfied that<br>coreboot shows recovery screen.<br><br>Change-Id: I47c59a32378ad00336277e111e81ba8d2d63e69a<br>Signed-off-by: Keith Short <keithshort@chromium.org><br>---<br>M src/drivers/i2c/tpm/cr50.c<br>1 file changed, 39 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/30295/3</pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30295">change 30295</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30295"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I47c59a32378ad00336277e111e81ba8d2d63e69a </div>
<div style="display:none"> Gerrit-Change-Number: 30295 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Edward Hill <ecgh@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Edward Hill <ecgh@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Keith Short <keithshort@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Bendebury <vbendeb@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>