<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30163">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/mb/google/*/Kconfig: Consistently use $(...) for variables<br><br>Using ${...} in some places is slightly confusing.<br><br>Fixes: 395cbb4f97 ("mb/*/*/Kconfig: Use CONFIG_VARIANT_DIR for devicetree")<br>Change-Id: Id0856a10d92786a41d45ca697945699f6f4c1f4c<br>Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net><br>Reviewed-on: https://review.coreboot.org/c/30163<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Patrick Georgi <pgeorgi@google.com><br>---<br>M src/mainboard/google/cyan/Kconfig<br>M src/mainboard/google/glados/Kconfig<br>M src/mainboard/google/kahlee/Kconfig<br>M src/mainboard/google/sarien/Kconfig<br>4 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig</span><br><span>index 917a66e..1d9b7b7 100644</span><br><span>--- a/src/mainboard/google/cyan/Kconfig</span><br><span>+++ b/src/mainboard/google/cyan/Kconfig</span><br><span>@@ -73,7 +73,7 @@</span><br><span> </span><br><span> config DEVICETREE</span><br><span>       string</span><br><span style="color: hsl(0, 100%, 40%);">-  default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"</span><br><span style="color: hsl(120, 100%, 40%);">+      default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"</span><br><span> </span><br><span> config VGA_BIOS_FILE</span><br><span>         string</span><br><span>diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig</span><br><span>index c5a80d4..80cc0f3 100644</span><br><span>--- a/src/mainboard/google/glados/Kconfig</span><br><span>+++ b/src/mainboard/google/glados/Kconfig</span><br><span>@@ -60,7 +60,7 @@</span><br><span> </span><br><span> config DEVICETREE</span><br><span>         string</span><br><span style="color: hsl(0, 100%, 40%);">-  default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"</span><br><span style="color: hsl(120, 100%, 40%);">+      default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"</span><br><span> </span><br><span> config MAX_CPUS</span><br><span>      int</span><br><span>diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig</span><br><span>index 97d15f5..13ad0b9 100644</span><br><span>--- a/src/mainboard/google/kahlee/Kconfig</span><br><span>+++ b/src/mainboard/google/kahlee/Kconfig</span><br><span>@@ -72,7 +72,7 @@</span><br><span> </span><br><span> config DEVICETREE</span><br><span>    string</span><br><span style="color: hsl(0, 100%, 40%);">-  default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"</span><br><span style="color: hsl(120, 100%, 40%);">+      default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"</span><br><span> </span><br><span> config MAINBOARD_FAMILY</span><br><span>      string</span><br><span>diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig</span><br><span>index c9e4c0b..c0bd1d8 100644</span><br><span>--- a/src/mainboard/google/sarien/Kconfig</span><br><span>+++ b/src/mainboard/google/sarien/Kconfig</span><br><span>@@ -88,7 +88,7 @@</span><br><span> </span><br><span> config DEVICETREE</span><br><span>         string</span><br><span style="color: hsl(0, 100%, 40%);">-  default "variants/${CONFIG_VARIANT_DIR}/devicetree.cb"</span><br><span style="color: hsl(120, 100%, 40%);">+      default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"</span><br><span> </span><br><span> config VBOOT</span><br><span>         select HAS_RECOVERY_MRC_CACHE</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30163">change 30163</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30163"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id0856a10d92786a41d45ca697945699f6f4c1f4c </div>
<div style="display:none"> Gerrit-Change-Number: 30163 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>