<p>Aamir Bohra has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30281">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/hatch: Add EC trigger events and acpi configs<br><br>This implemetation adds EC SCI, SMI, S5/S3 wake trigger events.<br>Also adds the EC specific ACPI configs.<br><br>Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a<br>Signed-off-by: Aamir Bohra <aamir.bohra@intel.com><br>---<br>A src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h<br>M src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h<br>2 files changed, 85 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/30281/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h</span><br><span>new file mode 100644</span><br><span>index 0000000..fab6260</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h</span><br><span>@@ -0,0 +1,81 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Intel Corporation.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef __BASEBOARD_EC_H__</span><br><span style="color: hsl(120, 100%, 40%);">+#define __BASEBOARD_EC_H__</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <ec/ec.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <ec/google/chromeec/ec_commands.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <variant/gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_EC_SCI_EVENTS \</span><br><span style="color: hsl(120, 100%, 40%);">+ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_LOW) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_EC_SMI_EVENTS \</span><br><span style="color: hsl(120, 100%, 40%);">+ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* EC can wake from S5 with lid or power button */</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_EC_S5_WAKE_EVENTS \</span><br><span style="color: hsl(120, 100%, 40%);">+ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * EC can wake from S3 with lid or power button or key press or</span><br><span style="color: hsl(120, 100%, 40%);">+ * mode change event.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_EC_S3_WAKE_EVENTS \</span><br><span style="color: hsl(120, 100%, 40%);">+ (MAINBOARD_EC_S5_WAKE_EVENTS |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Log EC wake events plus EC shutdown events */</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_EC_LOG_EVENTS \</span><br><span style="color: hsl(120, 100%, 40%);">+ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_SHUTDOWN) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_SHUTDOWN) |\</span><br><span style="color: hsl(120, 100%, 40%);">+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * ACPI related definitions for ASL code.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Enable EC backed ALS device in ACPI */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_ENABLE_ALS_DEVICE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Enable EC backed PD MCU device in ACPI */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_ENABLE_PD_MCU_DEVICE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Enable LID switch and provide wake pin for EC */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_ENABLE_LID_SWITCH</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */</span><br><span style="color: hsl(120, 100%, 40%);">+#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */</span><br><span style="color: hsl(120, 100%, 40%);">+#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* __BASEBOARD_EC_H__ */</span><br><span>diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h</span><br><span>index 7940cff..e537a93 100644</span><br><span>--- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h</span><br><span>+++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/gpio.h</span><br><span>@@ -24,4 +24,8 @@</span><br><span> #define GPIO_MEM_CONFIG_2 GPP_F11</span><br><span> #define GPIO_MEM_CONFIG_3 GPP_F22</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* EC wake is LAN_WAKE# which is a special DeepSX wake pin */</span><br><span style="color: hsl(120, 100%, 40%);">+#define GPE_EC_WAKE GPE0_LAN_WAK</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif /* BASEBOARD_GPIO_H */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30281">change 30281</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30281"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a </div>
<div style="display:none"> Gerrit-Change-Number: 30281 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>