<p><a href="https://review.coreboot.org/c/coreboot/+/25634">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c">File src/soc/intel/common/block/cpu/mp_service_ppi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c@47">Patch Set #44, Line 47:</a> <code style="font-family:monospace,monospace">    EFI_PEI_SERVICES **ignored1, EFI_PEI_MP_SERVICES_PPI *ignored2,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxO)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c@60">Patch Set #44, Line 60:</a> <code style="font-family:monospace,monospace">static EFI_STATUS mp_get_processor_info(CONST EFI_PEI_SERVICES **ignored1,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxO)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c@85">Patch Set #44, Line 85:</a> <code style="font-family:monospace,monospace">static EFI_STATUS mp_startup_all_aps(CONST EFI_PEI_SERVICES **ignored1,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxO)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c@104">Patch Set #44, Line 104:</a> <code style="font-family:monospace,monospace">static EFI_STATUS mp_startup_this_ap(CONST EFI_PEI_SERVICES **ignored1,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxO)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c@130">Patch Set #44, Line 130:</a> <code style="font-family:monospace,monospace">static EFI_STATUS mp_switch_bsp(CONST EFI_PEI_SERVICES **ignored1,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxO)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c@138">Patch Set #44, Line 138:</a> <code style="font-family:monospace,monospace">static EFI_STATUS mp_enable_disable_ap(CONST EFI_PEI_SERVICES **ignored1,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxO)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25634/44/src/soc/intel/common/block/cpu/mp_service_ppi.c@145">Patch Set #44, Line 145:</a> <code style="font-family:monospace,monospace">static EFI_STATUS mp_identify_processor(CONST EFI_PEI_SERVICES **PeiServices,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxO)</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/25634">change 25634</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/25634"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956 </div>
<div style="display:none"> Gerrit-Change-Number: 25634 </div>
<div style="display:none"> Gerrit-PatchSet: 44 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Idwer Vollering <vidwer@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Dec 2018 06:45:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>