<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30247">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google: Add GPU panel settings for SKL/KBL boards<br><br>The values are generated from the respective VBTs.<br><br>Change-Id: Ic74e9dac898c17ce64a94b06682997a39daeff69<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/mainboard/google/eve/devicetree.cb<br>M src/mainboard/google/fizz/variants/baseboard/devicetree.cb<br>M src/mainboard/google/glados/variants/asuka/devicetree.cb<br>M src/mainboard/google/glados/variants/caroline/devicetree.cb<br>M src/mainboard/google/glados/variants/cave/devicetree.cb<br>M src/mainboard/google/glados/variants/chell/devicetree.cb<br>M src/mainboard/google/glados/variants/glados/devicetree.cb<br>M src/mainboard/google/glados/variants/lars/devicetree.cb<br>M src/mainboard/google/glados/variants/sentry/devicetree.cb<br>9 files changed, 72 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/30247/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb</span><br><span>index 44449a5..f34a6c6 100644</span><br><span>--- a/src/mainboard/google/eve/devicetree.cb</span><br><span>+++ b/src/mainboard/google/eve/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "100"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "1"</span><br><span>diff --git a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb</span><br><span>index cc48498..3e088e3 100644</span><br><span>--- a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb</span><br><span>+++ b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "0"</span><br><span>diff --git a/src/mainboard/google/glados/variants/asuka/devicetree.cb b/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>index b9e87a8..bcd2546 100644</span><br><span>--- a/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "0"</span><br><span>diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>index 0c3c861..ff4859d 100644</span><br><span>--- a/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "0"</span><br><span>diff --git a/src/mainboard/google/glados/variants/cave/devicetree.cb b/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>index f512f9b..57bbce0 100644</span><br><span>--- a/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "0"</span><br><span>diff --git a/src/mainboard/google/glados/variants/chell/devicetree.cb b/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>index 3343aa0..8fc8e43 100644</span><br><span>--- a/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "0"</span><br><span>diff --git a/src/mainboard/google/glados/variants/glados/devicetree.cb b/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>index 2472dde..9339ce1 100644</span><br><span>--- a/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "0"</span><br><span>diff --git a/src/mainboard/google/glados/variants/lars/devicetree.cb b/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>index d552010..4f0be64 100644</span><br><span>--- a/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s5_enable_ac" = "1"</span><br><span> register "deep_s5_enable_dc" = "1"</span><br><span>diff --git a/src/mainboard/google/glados/variants/sentry/devicetree.cb b/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>index 7a89194..837cf58 100644</span><br><span>--- a/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>@@ -1,5 +1,13 @@</span><br><span> chip soc/intel/skylake</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_up_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_down_delay_ms" = " 50"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_cycle_delay_ms" = "500"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_on_delay_ms" = " 1"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pp_backlight_off_delay_ms" = "200"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ register "gpu_pch_backlight_pwm_hz" = "1000"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # Enable deep Sx states</span><br><span> register "deep_s3_enable_ac" = "0"</span><br><span> register "deep_s3_enable_dc" = "0"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30247">change 30247</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30247"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic74e9dac898c17ce64a94b06682997a39daeff69 </div>
<div style="display:none"> Gerrit-Change-Number: 30247 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>