<p><a href="https://review.coreboot.org/c/coreboot/+/30210">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30210/2/src/mainboard/google/hatch/variants/hatch/gpio.c">File src/mainboard/google/hatch/variants/hatch/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30210/2/src/mainboard/google/hatch/variants/hatch/gpio.c@23">Patch Set #2, Line 23:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* H1_SLAVE_SPI_CS_L */<br>PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1),<br>/* H1_SLAVE_SPI_CLK */<br>PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1),<br>/* H1_SLAVE_SPI_MISO_R */<br>PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),<br>/* H1_SLAVE_SPI_MOSI_R */<br>PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),<br>/* H1_PCH_INT_ODL */<br>PAD_CFG_GPI_APIC(GPP_C21, UP_20K, DEEP, EDGE_SINGLE, INVERT),<br><br>};<br><br>/* Early pad configuration in bootblock */<br>static const struct pad_config early_gpio_table[] = {<br><br>/* H1_SLAVE_SPI_CS_L */<br>PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1),<br>/* H1_SLAVE_SPI_CLK */<br>PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1),<br>/* H1_SLAVE_SPI_MISO_R */<br>PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),<br>/* H1_SLAVE_SPI_MOSI_R */<br>PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),<br>/* H1_PCH_INT_ODL */<br>PAD_CFG_GPI_APIC(GPP_C21, UP_20K, DEEP, EDGE_SINGLE, INVERT),<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can you indent these?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30210">change 30210</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30210"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib63a0b473f632d91745102ebd01993e8d65b9552 </div>
<div style="display:none"> Gerrit-Change-Number: 30210 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 14 Dec 2018 15:56:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>