<p><a href="https://review.coreboot.org/c/coreboot/+/30218">View Change</a></p><p>157 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/lib/prog_loaders.c">File src/lib/prog_loaders.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/lib/prog_loaders.c@81">Patch Set #1, Line 81:</a> <code style="font-family:monospace,monospace">int __weak prog_locate_hook(struct prog *prog) {return 0;}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ';' (ctx:VxV)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/include/cb_sha256.h">File src/security/include/cb_sha256.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/include/cb_sha256.h@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256(const uint8_t *data, uint64_t len, uint8_t *digest);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/include/cb_sha256.h@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256_ex(const uint8_t *data, uint64_t len, uint8_t *digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/include/cb_sha512.h">File src/security/include/cb_sha512.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/include/cb_sha512.h@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512(const uint8_t *data, uint64_t len, uint8_t *digest);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/include/cb_sha512.h@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512_ex(const uint8_t *data, uint64_t len, uint8_t *digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha1.c">File src/security/lib/cb_sha1.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha1.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t *cb_sha1(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha1.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t *cb_sha1(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c">File src/security/lib/cb_sha256.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256_ex(const uint8_t* data, uint64_t len, uint8_t* digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256_ex(const uint8_t* data, uint64_t len, uint8_t* digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256_ex(const uint8_t* data, uint64_t len, uint8_t* digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace"> const uint8_t* input_ptr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha256.c@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha256(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c">File src/security/lib/cb_sha512.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512_ex(const uint8_t* data, uint64_t len, uint8_t* digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512_ex(const uint8_t* data, uint64_t len, uint8_t* digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512_ex(const uint8_t* data, uint64_t len, uint8_t* digest,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace"> const uint8_t* input_ptr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/lib/cb_sha512.c@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace">uint8_t* cb_sha512(const uint8_t* data, uint64_t len, uint8_t* digest)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h">File src/security/mboot/mboot.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace">typedef struct tdTPM_DIGEST{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h@95">Patch Set #1, Line 95:</a> <code style="font-family:monospace,monospace">int is_zero_buffer(void *, unsigned int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'void *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h@95">Patch Set #1, Line 95:</a> <code style="font-family:monospace,monospace">int is_zero_buffer(void *, unsigned int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h@130">Patch Set #1, Line 130:</a> <code style="font-family:monospace,monospace">int log_event_tcg_20_format(TCG_PCR_EVENT2_HDR *, uint8_t *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'TCG_PCR_EVENT2_HDR *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h@130">Patch Set #1, Line 130:</a> <code style="font-family:monospace,monospace">int log_event_tcg_20_format(TCG_PCR_EVENT2_HDR *, uint8_t *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'uint8_t *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h@131">Patch Set #1, Line 131:</a> <code style="font-family:monospace,monospace">int log_event_tcg_12_format(TCG_PCR_EVENT2_HDR *, uint8_t *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'TCG_PCR_EVENT2_HDR *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.h@131">Patch Set #1, Line 131:</a> <code style="font-family:monospace,monospace">int log_event_tcg_12_format(TCG_PCR_EVENT2_HDR *, uint8_t *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'uint8_t *' should also have an identifier name</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c">File src/security/mboot/mboot.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"> if (!is_zero_buffer(</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (32, 48)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@52">Patch Set #1, Line 52:</a> <code style="font-family:monospace,monospace"> tpmHashAlgorithmBitmap |= EFI_TCG2_BOOT_HASH_ALG_SHA256;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace"> if (!is_zero_buffer(</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (32, 48)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@57">Patch Set #1, Line 57:</a> <code style="font-family:monospace,monospace"> EFI_TCG2_BOOT_HASH_ALG_SHA256;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@64">Patch Set #1, Line 64:</a> <code style="font-family:monospace,monospace"> "reported - 0x%x\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@105">Patch Set #1, Line 105:</a> <code style="font-family:monospace,monospace"> swab16(TpmCap.data.assignedPCR.pcrSelections[index].hash);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@109">Patch Set #1, Line 109:</a> <code style="font-family:monospace,monospace"> TpmCap.data.assignedPCR.pcrSelections[index].sizeofSelect;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@111">Patch Set #1, Line 111:</a> <code style="font-family:monospace,monospace"> TpmCap.data.assignedPCR.pcrSelections[index].pcrSelect,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@125">Patch Set #1, Line 125:</a> <code style="font-family:monospace,monospace"> * @param[in] flags flags associated with hash data. Currently unused.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@132">Patch Set #1, Line 132:</a> <code style="font-family:monospace,monospace"> * @retval TPM_SUCCESS Operation completed successfully.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@133">Patch Set #1, Line 133:</a> <code style="font-family:monospace,monospace"> * @retval TPM_E_IOERROR Unexpected device behavior.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@143">Patch Set #1, Line 143:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: Hash Data Length: %zu bytes\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@146">Patch Set #1, Line 146:</a> <code style="font-family:monospace,monospace"> if (invalid){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@170">Patch Set #1, Line 170:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: SHA1 Hash Digest:\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@170">Patch Set #1, Line 170:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: SHA1 Hash Digest:\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@171">Patch Set #1, Line 171:</a> <code style="font-family:monospace,monospace"> mboot_print_buffer (digest->digest.sha1, SHA1_DIGEST_SIZE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@171">Patch Set #1, Line 171:</a> <code style="font-family:monospace,monospace"> mboot_print_buffer (digest->digest.sha1, SHA1_DIGEST_SIZE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@185">Patch Set #1, Line 185:</a> <code style="font-family:monospace,monospace"> cb_sha256(hashData, hashDataLen, digest->digest.sha256);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@190">Patch Set #1, Line 190:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: SHA256 Hash Digest:\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@190">Patch Set #1, Line 190:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: SHA256 Hash Digest:\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@191">Patch Set #1, Line 191:</a> <code style="font-family:monospace,monospace"> mboot_print_buffer(digest->digest.sha256, SHA256_DIGEST_SIZE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@206">Patch Set #1, Line 206:</a> <code style="font-family:monospace,monospace"> /* If SHA1 PCR bank is active, log the event in TCG 1.2 format tool */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@213">Patch Set #1, Line 213:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: returned 0x%x\n", __FUNCTION__, status);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@233">Patch Set #1, Line 233:</a> <code style="font-family:monospace,monospace"> for (pcr=0; pcr < 8; pcr++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@234">Patch Set #1, Line 234:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: Invalidating PCR %d\n", __FUNCTION__, pcr);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@234">Patch Set #1, Line 234:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: Invalidating PCR %d\n", __FUNCTION__, pcr);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@246">Patch Set #1, Line 246:</a> <code style="font-family:monospace,monospace"> " 0x%x\n", __FUNCTION__, pcr, status);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@300">Patch Set #1, Line 300:</a> <code style="font-family:monospace,monospace"> * @param[in] type data type of the cbfs file.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@302">Patch Set #1, Line 302:</a> <code style="font-family:monospace,monospace"> * @param[in] evenType tcg event type.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@317">Patch Set #1, Line 317:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: Measure %s\n", __FUNCTION__, name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@321">Patch Set #1, Line 321:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: CBFS locate fail: %s\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@324">Patch Set #1, Line 324:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">else is not generally useful after a break or return</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@326">Patch Set #1, Line 326:</a> <code style="font-family:monospace,monospace"> __FUNCTION__, name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@362">Patch Set #1, Line 362:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: tlcl_lib_init\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@365">Patch Set #1, Line 365:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@370">Patch Set #1, Line 370:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: tlcl_resume\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@373">Patch Set #1, Line 373:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: tlcl_startup\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@378">Patch Set #1, Line 378:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "%s: StartUp failed 0x%x!\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@399">Patch Set #1, Line 399:</a> <code style="font-family:monospace,monospace"> * @retval TPM_SUCCESS Operation completed successfully.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@400">Patch Set #1, Line 400:</a> <code style="font-family:monospace,monospace"> * @retval TPM_E_IOERROR Unexpected device behavior.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@409">Patch Set #1, Line 409:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: StartUp, successful!\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@413">Patch Set #1, Line 413:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@418">Patch Set #1, Line 418:</a> <code style="font-family:monospace,monospace"> __FUNCTION__, status);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@423">Patch Set #1, Line 423:</a> <code style="font-family:monospace,monospace"> "PCRs invalidated.\n", __FUNCTION__, status);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@444">Patch Set #1, Line 444:</a> <code style="font-family:monospace,monospace"> * @retval TPM_SUCCESS Operation completed successfully.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@445">Patch Set #1, Line 445:</a> <code style="font-family:monospace,monospace"> * @retval TPM_E_IOERROR Unexpected device behavior.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@457">Patch Set #1, Line 457:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@466">Patch Set #1, Line 466:</a> <code style="font-family:monospace,monospace"> "can't be logged. ABORTING!!!\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@473">Patch Set #1, Line 473:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@476">Patch Set #1, Line 476:</a> <code style="font-family:monospace,monospace"> " ABORTING!!!\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@487">Patch Set #1, Line 487:</a> <code style="font-family:monospace,monospace"> if (status == TPM_SUCCESS)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that open brace { should be on the previous line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@490">Patch Set #1, Line 490:</a> <code style="font-family:monospace,monospace"> "%d.\n", __FUNCTION__, mb_log_list[i].cbfs_name,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@494">Patch Set #1, Line 494:</a> <code style="font-family:monospace,monospace"> "ABORTING!!!\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@502">Patch Set #1, Line 502:</a> <code style="font-family:monospace,monospace">static const uint8_t crtm_version[] = CONFIG_CRTM_VERSION_STRING \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Avoid unnecessary line continuations</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@523">Patch Set #1, Line 523:</a> <code style="font-family:monospace,monospace"> * @retval TPM_E_IOERROR Unexpected device behavior.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@532">Patch Set #1, Line 532:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: Measure CRTM Version\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@537">Patch Set #1, Line 537:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: EventSize - %u\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@560">Patch Set #1, Line 560:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@567">Patch Set #1, Line 567:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: EventSize - %u\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/mboot/mboot.c@587">Patch Set #1, Line 587:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "%s: returned 0x%x\n", __FUNCTION__, status);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss.h">File src/security/tpm/tss.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss.h@132">Patch Set #1, Line 132:</a> <code style="font-family:monospace,monospace"> TPMS_CAPABILITY_DATA *CapabilityData );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c">File src/security/tpm/tss/tcg-2.0/tss.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@216">Patch Set #1, Line 216:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: pcr = %d\n", __FUNCTION__, pcr_num );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@216">Patch Set #1, Line 216:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: pcr = %d\n", __FUNCTION__, pcr_num );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@217">Patch Set #1, Line 217:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: in_digests->count = %d\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@224">Patch Set #1, Line 224:</a> <code style="font-family:monospace,monospace"> memcpy( (void *) pcr_ext_cmd.digests.digests[i].digest.sha256,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited after that open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@228">Patch Set #1, Line 228:</a> <code style="font-family:monospace,monospace"> printk (BIOS_SPEW, "%s: in_digests[%d]->hash_alg = 0x%x\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@229">Patch Set #1, Line 229:</a> <code style="font-family:monospace,monospace"> __FUNCTION__, i, in_digests->digests[i].hashAlg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@235">Patch Set #1, Line 235:</a> <code style="font-family:monospace,monospace"> // Check if we are invalidating the pcrs, ignore the error if this is the case</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@239">Patch Set #1, Line 239:</a> <code style="font-family:monospace,monospace"> if (in_digests->digests[0].digest.invalidate_pcrs == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@246">Patch Set #1, Line 246:</a> <code style="font-family:monospace,monospace"> " expected\n", __func__ );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@290">Patch Set #1, Line 290:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: tlcl_init_done is %d\n", __FUNCTION__, done );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@290">Patch Set #1, Line 290:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: tlcl_init_done is %d\n", __FUNCTION__, done );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@294">Patch Set #1, Line 294:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: calling tis_init\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@296">Patch Set #1, Line 296:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "%s: tis_init returned error\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@300">Patch Set #1, Line 300:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: calling tis_open\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@302">Patch Set #1, Line 302:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "%s: tis_open returned error\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@501">Patch Set #1, Line 501:</a> <code style="font-family:monospace,monospace"> " yet\n", __func__ );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@504">Patch Set #1, Line 504:</a> <code style="font-family:monospace,monospace"> response = tpm_process_command_ex(TPM2_GetCapability, &cmd, 0, &response_size, 1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@507">Patch Set #1, Line 507:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "%s: Command Failed\n", __func__ );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@530">Patch Set #1, Line 530:</a> <code style="font-family:monospace,monospace"> for (index = 0; index < sizeof(mHashInfo)/sizeof(mHashInfo[0]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 24)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@530">Patch Set #1, Line 530:</a> <code style="font-family:monospace,monospace"> for (index = 0; index < sizeof(mHashInfo)/sizeof(mHashInfo[0]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer ARRAY_SIZE(mHashInfo)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@535">Patch Set #1, Line 535:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: unknown hash algorithm %d\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss.c@536">Patch Set #1, Line 536:</a> <code style="font-family:monospace,monospace"> hashAlgo );</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss_structures.h">File src/security/tpm/tss/tcg-2.0/tss_structures.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/tpm/tss/tcg-2.0/tss_structures.h@269">Patch Set #1, Line 269:</a> <code style="font-family:monospace,monospace"> TPMI_ALG_HASH hash;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c">File src/security/verified_boot/vboot_check.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace"> uint8_t* signature = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@62">Patch Set #1, Line 62:</a> <code style="font-family:monospace,monospace"> cb_sha512_ex((const uint8_t*)CONFIG_OEM_MANIFEST_LOC,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@65">Patch Set #1, Line 65:</a> <code style="font-family:monospace,monospace"> cb_sha256_ex((const uint8_t*)CONFIG_OEM_MANIFEST_LOC,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@69">Patch Set #1, Line 69:</a> <code style="font-family:monospace,monospace"> signature = (uint8_t*)CONFIG_OEM_MANIFEST_LOC +</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@80">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@123">Patch Set #1, Line 123:</a> <code style="font-family:monospace,monospace"> (uint8_t*)event_msg, 0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@126">Patch Set #1, Line 126:</a> <code style="font-family:monospace,monospace"> "%d.\n", __FUNCTION__, event_msg, pcr);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@129">Patch Set #1, Line 129:</a> <code style="font-family:monospace,monospace"> "ABORTING!!!\n", __FUNCTION__, event_msg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@143">Patch Set #1, Line 143:</a> <code style="font-family:monospace,monospace"> ,int32_t pcr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:ExV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@155">Patch Set #1, Line 155:</a> <code style="font-family:monospace,monospace"> __FUNCTION__, name, start, (int) size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@160">Patch Set #1, Line 160:</a> <code style="font-family:monospace,monospace"> cb_sha512((const uint8_t*)start, size, digest);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@162">Patch Set #1, Line 162:</a> <code style="font-family:monospace,monospace"> cb_sha256((const uint8_t*)start, size, digest);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@167">Patch Set #1, Line 167:</a> <code style="font-family:monospace,monospace"> printk(BIOS_INFO, "%s: buffer hash\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@169">Patch Set #1, Line 169:</a> <code style="font-family:monospace,monospace"> printk(BIOS_INFO, "%s: manifest hash\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@179">Patch Set #1, Line 179:</a> <code style="font-family:monospace,monospace"> __FUNCTION__, name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@199">Patch Set #1, Line 199:</a> <code style="font-family:monospace,monospace"> ,int32_t pcr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:ExV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@215">Patch Set #1, Line 215:</a> <code style="font-family:monospace,monospace"> if ((type & VERIFIED_BOOT_COPY_BLOCK) && (buffer) && (*buffer)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (16, 32)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@219">Patch Set #1, Line 219:</a> <code style="font-family:monospace,monospace"> "memory\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@225">Patch Set #1, Line 225:</a> <code style="font-family:monospace,monospace"> printk(BIOS_INFO, "%s: done\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@231">Patch Set #1, Line 231:</a> <code style="font-family:monospace,monospace"> ,pcr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:ExV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@251">Patch Set #1, Line 251:</a> <code style="font-family:monospace,monospace"> switch (list[i].type) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">switch and case should be at the same indent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@258">Patch Set #1, Line 258:</a> <code style="font-family:monospace,monospace"> ,list[i].pcr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:ExV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@266">Patch Set #1, Line 266:</a> <code style="font-family:monospace,monospace"> list[i].data.file.related_items);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@276">Patch Set #1, Line 276:</a> <code style="font-family:monospace,monospace"> ,list[i].pcr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:ExV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@297">Patch Set #1, Line 297:</a> <code style="font-family:monospace,monospace"> switch (list[i].type) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">switch and case should be at the same indent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@303">Patch Set #1, Line 303:</a> <code style="font-family:monospace,monospace"> process_verify_list((verify_item_t *)list[i].data.file.related_items);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@313">Patch Set #1, Line 313:</a> <code style="font-family:monospace,monospace"> ,list[i].pcr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:ExV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@341">Patch Set #1, Line 341:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: processing bootblock items\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@344">Patch Set #1, Line 344:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: check the manifest\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@348">Patch Set #1, Line 348:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: process bootblock verify list\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@375">Patch Set #1, Line 375:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: processing early items\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@379">Patch Set #1, Line 379:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: check the manifest\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@384">Patch Set #1, Line 384:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: process early verify list\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@414">Patch Set #1, Line 414:</a> <code style="font-family:monospace,monospace"> switch (list[i].type) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">switch and case should be at the same indent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@422">Patch Set #1, Line 422:</a> <code style="font-family:monospace,monospace"> ,list[i].pcr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:ExV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@428">Patch Set #1, Line 428:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@429">Patch Set #1, Line 429:</a> <code style="font-family:monospace,monospace"> process_verify_list((verify_item_t *)list[i].data.oprom.related_items);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@432">Patch Set #1, Line 432:</a> <code style="font-family:monospace,monospace"> "be started\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@438">Patch Set #1, Line 438:</a> <code style="font-family:monospace,monospace"> " ROM LIST 0x%x\n", __FUNCTION__,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@445">Patch Set #1, Line 445:</a> <code style="font-family:monospace,monospace"> __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@454">Patch Set #1, Line 454:</a> <code style="font-family:monospace,monospace"> void *buffer = (void*) 0x01000000;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"(foo*)" should be "(foo *)"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@455">Patch Set #1, Line 455:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: requesting %s\n", __FUNCTION__, prog->name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@455">Patch Set #1, Line 455:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: requesting %s\n", __FUNCTION__, prog->name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@456">Patch Set #1, Line 456:</a> <code style="font-family:monospace,monospace"> process_named_list(payload_verify_list, prog->name, &buffer, NULL);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30218/1/src/security/verified_boot/vboot_check.c@457">Patch Set #1, Line 457:</a> <code style="font-family:monospace,monospace"> printk(BIOS_SPEW, "%s: running allowed\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30218">change 30218</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30218"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80 </div>
<div style="display:none"> Gerrit-Change-Number: 30218 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 14 Dec 2018 11:28:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>