<p>Lijian Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30207">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Add Acoustic features<br><br>Expose the following FSP UPD interface into coreboot, which is the<br>following:<br>AcousticNoiseMitigation<br>FastPkgCRampDisableIa<br>FastPkgCRampDisableGt<br>FastPkgCRampDisableSa<br>FastPkgCRampDisableFivr<br>SlowSlewRateForIa<br>SlowSlewRateForGt<br>SlowSlewRateForSa<br>SlowSlewRateForFivr<br><br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>Change-Id: I21f53c594a085794474e87eb6781b51db88d0c10<br>---<br>M src/soc/intel/cannonlake/chip.h<br>M src/soc/intel/cannonlake/fsp_params.c<br>2 files changed, 42 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/30207/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h</span><br><span>index 9eb91bd..8eaf02b 100644</span><br><span>--- a/src/soc/intel/cannonlake/chip.h</span><br><span>+++ b/src/soc/intel/cannonlake/chip.h</span><br><span>@@ -263,6 +263,37 @@</span><br><span> /* Intel VT configuration */</span><br><span> uint8_t VtdDisable;</span><br><span> uint8_t VmxEnable;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Acoustic Noise Mitigation</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b - Disable</span><br><span style="color: hsl(120, 100%, 40%);">+ * 1b - Enable noise mitigation</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t AcousticNoiseMitigation;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Disable Fast Package C-state ramping</span><br><span style="color: hsl(120, 100%, 40%);">+ * Need to set AcousticNoiseMitigation = '1' first</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b - Enabled</span><br><span style="color: hsl(120, 100%, 40%);">+ * 1b - Disabled</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t FastPkgCRampDisableIa;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t FastPkgCRampDisableGt;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t FastPkgCRampDisableSa;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t FastPkgCRampDisableFivr;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Adjust the VR slew rates</span><br><span style="color: hsl(120, 100%, 40%);">+ * Need to set AcousticNoiseMitigation = '1' first</span><br><span style="color: hsl(120, 100%, 40%);">+ * 000b - Fast/2</span><br><span style="color: hsl(120, 100%, 40%);">+ * 001b - Fast/4</span><br><span style="color: hsl(120, 100%, 40%);">+ * 010b - Fast/8</span><br><span style="color: hsl(120, 100%, 40%);">+ * 011b - Fast/16</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t SlowSlewRateForIa;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t SlowSlewRateForGt;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t SlowSlewRateForSa;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t SlowSlewRateForFivr;</span><br><span> };</span><br><span> </span><br><span> typedef struct soc_intel_cannonlake_config config_t;</span><br><span>diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c</span><br><span>index f957459..a9326a4 100644</span><br><span>--- a/src/soc/intel/cannonlake/fsp_params.c</span><br><span>+++ b/src/soc/intel/cannonlake/fsp_params.c</span><br><span>@@ -210,6 +210,17 @@</span><br><span> * 3 = GT unsliced, 4 = GT sliced */</span><br><span> for (i = 0; i < ARRAY_SIZE(config->domain_vr_config); i++)</span><br><span> fill_vr_domain_config(params, i, &config->domain_vr_config[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Acoustic Noise Mitigation */</span><br><span style="color: hsl(120, 100%, 40%);">+ params->AcousticNoiseMitigation = config->AcousticNoiseMitigation;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->SlowSlewRateForIa = config->SlowSlewRateForIa;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->SlowSlewRateForGt = config->SlowSlewRateForGt;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->SlowSlewRateForSa = config->SlowSlewRateForSa;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->SlowSlewRateForFivr = config->SlowSlewRateForFivr;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->FastPkgCRampDisableIa = config->FastPkgCRampDisableIa;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->FastPkgCRampDisableGt = config->FastPkgCRampDisableGt;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->FastPkgCRampDisableSa = config->FastPkgCRampDisableSa;</span><br><span style="color: hsl(120, 100%, 40%);">+ params->FastPkgCRampDisableFivr = config->FastPkgCRampDisableFivr;</span><br><span> }</span><br><span> </span><br><span> /* Mainboard GPIO Configuration */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30207">change 30207</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30207"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I21f53c594a085794474e87eb6781b51db88d0c10 </div>
<div style="display:none"> Gerrit-Change-Number: 30207 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>