<p><a href="https://review.coreboot.org/c/coreboot/+/30182">View Change</a></p><p>21 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.h">File src/drivers/intel/fb/fbdriver.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.h@8">Patch Set #1, Line 8:</a> <code style="font-family:monospace,monospace"> FB_POS_CENTER=0,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.h@12">Patch Set #1, Line 12:</a> <code style="font-family:monospace,monospace">}FB_POS;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c">File src/drivers/intel/fb/fbdriver.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> unsigned char *glyph = font8x16 + ((ch & 0xFF) * FONT_HEIGHT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> unsigned char *glyph = font8x16 + ((ch & 0xFF) * FONT_HEIGHT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@42">Patch Set #1, Line 42:</a> <code style="font-family:monospace,monospace"> return glyph[y/FONT_SCALE] & (1 << x/FONT_SCALE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@42">Patch Set #1, Line 42:</a> <code style="font-family:monospace,monospace"> return glyph[y/FONT_SCALE] & (1 << x/FONT_SCALE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace"> status = fsp_fill_lb_framebuffer (&fb_info);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@59">Patch Set #1, Line 59:</a> <code style="font-family:monospace,monospace"> printk (BIOS_DEBUG, "Inverse framebuffer color\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@61">Patch Set #1, Line 61:</a> <code style="font-family:monospace,monospace"> memset ((void *)FB, 0xffffffff, bytes);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@67">Patch Set #1, Line 67:</a> <code style="font-family:monospace,monospace">void intelfb_destroy()</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Bad function definition - void intelfb_destroy() should probably be void intelfb_destroy(void)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@77">Patch Set #1, Line 77:</a> <code style="font-family:monospace,monospace">void intelfb_clear()</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Bad function definition - void intelfb_clear() should probably be void intelfb_clear(void)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@100">Patch Set #1, Line 100:</a> <code style="font-family:monospace,monospace"> for(y = 0; y < font_height; y++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@101">Patch Set #1, Line 101:</a> <code style="font-family:monospace,monospace"> for(x = font_width - 1; x >= 0; x--) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@102">Patch Set #1, Line 102:</a> <code style="font-family:monospace,monospace"> dst32 = (u32 *)(dst + (font_width - x) * (FI.bits_per_pixel >> 3));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@104">Patch Set #1, Line 104:</a> <code style="font-family:monospace,monospace"> *dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@104">Patch Set #1, Line 104:</a> <code style="font-family:monospace,monospace"> *dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that ':' (ctx:VxW)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@106">Patch Set #1, Line 106:</a> <code style="font-family:monospace,monospace"> *dst32 = font_glyph_filled(ch, x, y) ? 0xffffffff : 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@126">Patch Set #1, Line 126:</a> <code style="font-family:monospace,monospace"> switch(position){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@126">Patch Set #1, Line 126:</a> <code style="font-family:monospace,monospace"> switch(position){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@136">Patch Set #1, Line 136:</a> <code style="font-family:monospace,monospace"> int_row = (4 *(vres / 5)) - (4 * FONT_SCALE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@147">Patch Set #1, Line 147:</a> <code style="font-family:monospace,monospace"> for(index = 0; index < len; index++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30182">change 30182</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30182"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I70715d9c84dae2d0efa1631649ce27ea3c39e237 </div>
<div style="display:none"> Gerrit-Change-Number: 30182 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Dec 2018 08:28:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>