<p>Karthik Ramasubramanian would like Karthikeyan Ramasubramanian to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30171">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus/ampton: Fix the TRACKPAD_INT_ODL GPIO configuration<br><br>Update the TRACKPAD_INT1_1V8_ODL GPIO configuration so that it acts as a<br>wakeup source<br><br>BUG=b:119598593<br>BRANCH=octopus<br>TEST=Ensure that the system wakes up on trackpad events. Ensure that the<br>suspend_stress_test runs successfully for 25 iterations.<br><br>Change-Id: I28292682cf9c8037abb87d265e49a60139550db2<br>Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org><br>---<br>M src/mainboard/google/octopus/variants/ampton/gpio.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/30171/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/ampton/gpio.c b/src/mainboard/google/octopus/variants/ampton/gpio.c</span><br><span>index 893e0fa..f34645d 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/ampton/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/ampton/gpio.c</span><br><span>@@ -195,7 +195,8 @@</span><br><span>        PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* HV_EDP_HPD */</span><br><span> </span><br><span>        PAD_NC(GPIO_134, NONE),/* GPIO_134 -- EC_AP_INT_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">-  PAD_CFG_GPI_APIC_IOS(GPIO_135, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+   /* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+       PAD_CFG_GPI_IRQ_WAKE(GPIO_135, NONE, DEEP, LEVEL, INVERT),</span><br><span>   PAD_CFG_GPI_APIC_IOS(GPIO_136, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_136 -- PMIC_PCH_INT_ODL */</span><br><span>        PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP, EDGE_BOTH, INVERT, HIZCRx1,</span><br><span>                               DISPUPD),/* GPIO_137 -- HP_INT_ODL */</span><br><span>@@ -204,7 +205,7 @@</span><br><span>  PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */</span><br><span>       // Also we may be able to use eSPI WAKE# Virtual Wire instead</span><br><span>        PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">-       PAD_CFG_GPI_SCI_LOW(GPIO_142, NONE, DEEP, LEVEL),/* GPIO_142 -- TRACKPAD_INT2_1V8_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+      PAD_NC(GPIO_142, UP_20K),/* GPIO_142 -- TRACKPAD_INT2_1V8_ODL(unused) */</span><br><span>     PAD_NC(GPIO_143, UP_20K), /* GPIO_143 - NC */</span><br><span>        PAD_NC(GPIO_144, UP_20K), /* GPIO_144 - PEN_EJECT */</span><br><span>         PAD_NC(GPIO_145, UP_20K), /* GPIO_145 - PEN_EJECT */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30171">change 30171</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30171"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I28292682cf9c8037abb87d265e49a60139550db2 </div>
<div style="display:none"> Gerrit-Change-Number: 30171 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>