<p>Tristan Corrick has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30149">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sb/intel/lynxpoint: Remove incomplete SATA ACPI code<br><br>The existing SATA ACPI code for Lynx Point implements some methods and<br>devices, but not completely. These methods are optional and only used in<br>IDE mode. The code was likely copied from bd82x6x, where it has since<br>been removed.<br><br>As a result, many remarks produced by iasl about unreferenced objects<br>are eliminated.<br><br>Tested on an ASRock H81M-HDS and an Acer C720. No issues with SATA<br>were observed.<br><br>Change-Id: I808a9dff7b9ba34239ffd95fa4cb9b39b10c4b62<br>Signed-off-by: Tristan Corrick <tristan@corrick.kiwi><br>---<br>M src/southbridge/intel/lynxpoint/acpi/sata.asl<br>1 file changed, 0 insertions(+), 52 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/30149/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/southbridge/intel/lynxpoint/acpi/sata.asl b/src/southbridge/intel/lynxpoint/acpi/sata.asl</span><br><span>index 44ce576..3c01893 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/acpi/sata.asl</span><br><span>+++ b/src/southbridge/intel/lynxpoint/acpi/sata.asl</span><br><span>@@ -22,56 +22,4 @@</span><br><span> Device (SATA)</span><br><span> {</span><br><span> Name (_ADR, 0x001f0002)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PRID)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_ADR, 0)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- // Get Timing Mode</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_GTM, 0, Serialized)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(PBUF, Buffer(20) {</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00,0x00,0x00,0x00 })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (PBUF, 0, PIO0)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (PBUF, 4, DMA0)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (PBUF, 8, PIO1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (PBUF, 12, DMA1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (PBUF, 16, FLAG)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- // TODO fill return structure</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Return (PBUF)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- // Set Timing Mode</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_STM, 3)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (Arg0, 0, PIO0)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (Arg0, 4, DMA0)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (Arg0, 8, PIO1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (Arg0, 12, DMA1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDwordField (Arg0, 16, FLAG)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- // TODO: Do the deed</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device (DSK0)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_ADR, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- // TODO: _RMV ?</span><br><span style="color: hsl(0, 100%, 40%);">- // TODO: _GTF ?</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device (DSK1)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_ADR, 1)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- // TODO: _RMV ?</span><br><span style="color: hsl(0, 100%, 40%);">- // TODO: _GTF ?</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30149">change 30149</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30149"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I808a9dff7b9ba34239ffd95fa4cb9b39b10c4b62 </div>
<div style="display:none"> Gerrit-Change-Number: 30149 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Corrick <tristan@corrick.kiwi> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>