<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30092">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Raul Rangel: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libpayload: Don't try to use invalid row count<br><br>console->scroll_up() was hanging when console->rows is 0.  This<br>was happening on delan if no screen was attached.  If there are no<br>rows, just return.<br><br>BUG=b:119234919<br>TEST=Boot delan with no flat panel.  System boots to OS<br><br>Change-Id: Ib022d3c6fc0c9cf360809dca28761a50c787304a<br>Signed-off-by: Martin Roth <martinroth@chromium.org><br>Reviewed-on: https://review.coreboot.org/c/30092<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Raul Rangel <rrangel@chromium.org><br>---<br>M payloads/libpayload/drivers/video/video.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/libpayload/drivers/video/video.c b/payloads/libpayload/drivers/video/video.c</span><br><span>index 71140f0..b932a63 100644</span><br><span>--- a/payloads/libpayload/drivers/video/video.c</span><br><span>+++ b/payloads/libpayload/drivers/video/video.c</span><br><span>@@ -87,6 +87,9 @@</span><br><span>          cursory++;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (console->rows <= 0)</span><br><span style="color: hsl(120, 100%, 40%);">+         return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    while(cursory >= console->rows) {</span><br><span>              console->scroll_up();</span><br><span>             cursory--;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30092">change 30092</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30092"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib022d3c6fc0c9cf360809dca28761a50c787304a </div>
<div style="display:none"> Gerrit-Change-Number: 30092 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Simon Glass <sjg@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>