<p>Tristan Corrick <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30077">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sb/intel/lynxpoint: Handle H81 only having 6 PCIe root ports<br><br>The H81 chipset is the only non-LP Lynx Point chipset with 6 PCIe root<br>ports, all others have 8 [1]. The existing PCIe code assumed that all<br>non-LP chipsets had 8 root ports, which meant that port 6 would not be<br>considered the last root port on H81, so `root_port_commit_config()`<br>would not run. Ultimately, while PCIe still worked on H81, all the root<br>ports would remain enabled, even if disabled in the devicetree.<br><br>Also, remove `PCI_DEVICE_ID_INTEL_LYNXPOINT_MOB_DESK_{MIN,MAX}`, as they<br>are unused, and the MAX constant is incorrect.<br><br>Interestingly, this fixes an issue where GRUB is unable to halt the<br>system.<br><br>Tested on an ASRock H81M-HDS. The root ports disabled in the devicetree<br>do indeed end up disabled.<br><br>[1] Intel® 8 Series/C220 Series Chipset Family Platform Controller Hub<br>    (PCH) Datasheet, revision 003, document number 328904.<br><br>Change-Id: If3ce217e8a4f4ea4e111e4525b03dbbfc63f92b0<br>Signed-off-by: Tristan Corrick <tristan@corrick.kiwi><br>---<br>M src/include/device/pci_ids.h<br>M src/mainboard/asrock/h81m-hds/devicetree.cb<br>M src/southbridge/intel/lynxpoint/pch.c<br>M src/southbridge/intel/lynxpoint/pch.h<br>M src/southbridge/intel/lynxpoint/pcie.c<br>5 files changed, 38 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/30077/2</pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30077">change 30077</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30077"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If3ce217e8a4f4ea4e111e4525b03dbbfc63f92b0 </div>
<div style="display:none"> Gerrit-Change-Number: 30077 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Tristan Corrick <tristan@corrick.kiwi> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>