<p><a href="https://review.coreboot.org/c/coreboot/+/30103">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c">File src/cpu/intel/common/fsb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c@23">Patch Set #2, Line 23:</a> <code style="font-family:monospace,monospace">int</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">static const short</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c@54">Patch Set #2, Line 54:</a> <code style="font-family:monospace,monospace">0x4</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do you want to add names here too ?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h">File src/include/cpu/intel/fsb.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h@17">Patch Set #2, Line 17:</a> <code style="font-family:monospace,monospace">get_ia32_fsb(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add description.<br>What is returned on error?<br>What unit does the returned value have</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30103">change 30103</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30103"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28 </div>
<div style="display:none"> Gerrit-Change-Number: 30103 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 08 Dec 2018 17:19:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>