<p>Duncan Laurie <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30113">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/sarien: Setup GPIOs again after FSP-S<br><br>Currently CoffeeLake FSP is incorrectly modifying GPIO pad configuration<br>if specific UPD variables are not set as it expects.<br><br>This affects the display-related SOC pads with the following UPD variables:<br><br>UINT8 DdiPortBHpd; // GPP_E13<br>UINT8 DdiPortCHpd; // GPP_E14<br>UINT8 DdiPortDHpd; // GPP_E15<br>UINT8 DdiPortFHpd; // GPP_E16<br>UINT8 DdiPortBDdc; // GPP_E18/GPP_E19<br>UINT8 DdiPortCDdc; // GPP_E20/GPP_E21<br>UINT8 DdiPortDDdc; // GPP_E22/GPP_E23<br>UINT8 DdiPortFDdc; // GPP_H16/GPP_H17<br><br>Until FSP is fixed to not touch the pad configuration this workaround<br>will reprogram the GPIO settings after FSP-S step so they are correct<br>when the OS attempts to use them.<br><br>This was found in CoffeLake FSP Gold release:<br>https://github.com/IntelFsp/FSP/tree/master/CoffeeLakeFspBinPkg<br><br>As well as the current top-of-tree for the FSP sources.<br><br>BUG=b:120686247,chromium:913216<br>TEST=verify correct GPIO configuration for GPP_E group in the kernel<br><br>Change-Id: I19550c4347cf65d409de6a8638619270372c4d0a<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/mainboard/google/sarien/ramstage.c<br>1 file changed, 11 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/30113/2</pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30113">change 30113</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30113"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I19550c4347cf65d409de6a8638619270372c4d0a </div>
<div style="display:none"> Gerrit-Change-Number: 30113 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>