<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30084">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cbfs: Alert if something goes wrong in cbfs_boot_locate()<br><br>Change-Id: I5a3cb41b3a7ff2aa527cc2b40c9d7438474c2f93<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>---<br>M src/lib/cbfs.c<br>1 file changed, 9 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/30084/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c</span><br><span>index 9ea7df6..a5c9f85 100644</span><br><span>--- a/src/lib/cbfs.c</span><br><span>+++ b/src/lib/cbfs.c</span><br><span>@@ -41,17 +41,23 @@</span><br><span>       const struct region_device *boot_dev;</span><br><span>        struct cbfs_props props;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    if (cbfs_boot_region_properties(&props))</span><br><span style="color: hsl(120, 100%, 40%);">+  if (cbfs_boot_region_properties(&props)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                printk(BIOS_ALERT, "ERROR: Failed to locate boot region\n");</span><br><span>               return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        /* All boot CBFS operations are performed using the RO device. */</span><br><span>    boot_dev = boot_device_ro();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        if (boot_dev == NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (boot_dev == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+               printk(BIOS_ALERT, "ERROR: Failed to find boot device\n");</span><br><span>                 return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (rdev_chain(&rdev, boot_dev, props.offset, props.size))</span><br><span style="color: hsl(120, 100%, 40%);">+        if (rdev_chain(&rdev, boot_dev, props.offset, props.size)) {</span><br><span style="color: hsl(120, 100%, 40%);">+              printk(BIOS_ALERT, "ERROR: Failed to access boot region inside boot device\n");</span><br><span>            return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span> </span><br><span>        return cbfs_locate(fh, &rdev, name, type);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30084">change 30084</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30084"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5a3cb41b3a7ff2aa527cc2b40c9d7438474c2f93 </div>
<div style="display:none"> Gerrit-Change-Number: 30084 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>