<p>Karthik Ramasubramanian would like Karthikeyan Ramasubramanian to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30074">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Print ME version on exit of BS_DEV_INIT stage<br><br>Print ME version on exit of BS_DEV_INIT stage so that the HECI device<br>stays in D3 state as configured by FSP.<br><br>BRANCH=octopus<br>BUG=b:120571529<br>TEST=Ensure that the ME version gets printed in BIOS logs. Ensure that<br>the device boots to ChromeOS. Ensure that the device enters S0ix<br>successfully(using suspend_stress_test -c 25).<br><br>Change-Id: I85bc45003a040c8347f929457792d78a9a077c6c<br>Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com><br>---<br>M src/soc/intel/apollolake/cse.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/30074/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/cse.c b/src/soc/intel/apollolake/cse.c</span><br><span>index 26249bc..d761a6c 100644</span><br><span>--- a/src/soc/intel/apollolake/cse.c</span><br><span>+++ b/src/soc/intel/apollolake/cse.c</span><br><span>@@ -195,7 +195,7 @@</span><br><span>  return reg;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void dump_cse_version(void)</span><br><span style="color: hsl(120, 100%, 40%);">+static void dump_cse_version(void *unused)</span><br><span> {</span><br><span>      int res;</span><br><span>     size_t reply_size;</span><br><span>@@ -282,8 +282,6 @@</span><br><span>             printk(BIOS_DEBUG, "unknown");</span><br><span>     }</span><br><span>    printk(BIOS_DEBUG, "\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-     dump_cse_version();</span><br><span> }</span><br><span> </span><br><span> #define PCR_PSFX_T0_SHDW_PCIEN          0x1C</span><br><span>@@ -307,3 +305,4 @@</span><br><span> }</span><br><span> </span><br><span> BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_ENTRY, fpf_blown, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, dump_cse_version, NULL);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30074">change 30074</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30074"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I85bc45003a040c8347f929457792d78a9a077c6c </div>
<div style="display:none"> Gerrit-Change-Number: 30074 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>