<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30047">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src: Get rid of device_t<br><br>Use of device_t is deprecated.<br><br>Change-Id: Ie05869901ac33d7089e21110f46c1241f7ee731f<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/arch/arm/include/arch/pci_ops.h<br>M src/arch/arm64/include/arch/pci_ops.h<br>M src/arch/mips/include/arch/pci_ops.h<br>M src/arch/x86/include/arch/io.h<br>M src/device/pci_early.c<br>M src/include/device/device.h<br>M src/include/device/pci_ops.h<br>M src/include/device/smbus.h<br>M src/include/reg_script.h<br>M src/lib/reg_script.c<br>10 files changed, 87 insertions(+), 48 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/30047/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/arm/include/arch/pci_ops.h b/src/arch/arm/include/arch/pci_ops.h</span><br><span>index 2e2661b..533ad80 100644</span><br><span>--- a/src/arch/arm/include/arch/pci_ops.h</span><br><span>+++ b/src/arch/arm/include/arch/pci_ops.h</span><br><span>@@ -21,9 +21,6 @@</span><br><span> typedef u32 pci_devfn_t;</span><br><span> </span><br><span> #ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(0, 100%, 40%);">-// FIXME: Use of device_t is deprecated</span><br><span style="color: hsl(0, 100%, 40%);">-typedef pci_devfn_t device_t;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> u8 pci_read_config8(pci_devfn_t dev, unsigned int where);</span><br><span> u16 pci_read_config16(pci_devfn_t dev, unsigned int where);</span><br><span> u32 pci_read_config32(pci_devfn_t dev, unsigned int where);</span><br><span>diff --git a/src/arch/arm64/include/arch/pci_ops.h b/src/arch/arm64/include/arch/pci_ops.h</span><br><span>index e6d5206..32e7601 100644</span><br><span>--- a/src/arch/arm64/include/arch/pci_ops.h</span><br><span>+++ b/src/arch/arm64/include/arch/pci_ops.h</span><br><span>@@ -21,9 +21,6 @@</span><br><span> typedef u32 pci_devfn_t;</span><br><span> </span><br><span> #ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(0, 100%, 40%);">-// FIXME: Use of device_t is deprecated</span><br><span style="color: hsl(0, 100%, 40%);">-typedef pci_devfn_t device_t;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> u8 pci_read_config8(pci_devfn_t dev, unsigned int where);</span><br><span> u16 pci_read_config16(pci_devfn_t dev, unsigned int where);</span><br><span> u32 pci_read_config32(pci_devfn_t dev, unsigned int where);</span><br><span>diff --git a/src/arch/mips/include/arch/pci_ops.h b/src/arch/mips/include/arch/pci_ops.h</span><br><span>index 5fef126..f57befa 100644</span><br><span>--- a/src/arch/mips/include/arch/pci_ops.h</span><br><span>+++ b/src/arch/mips/include/arch/pci_ops.h</span><br><span>@@ -21,9 +21,6 @@</span><br><span> typedef u32 pci_devfn_t;</span><br><span> </span><br><span> #ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(0, 100%, 40%);">-// FIXME: Use of device_t is deprecated</span><br><span style="color: hsl(0, 100%, 40%);">-typedef pci_devfn_t device_t;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> u8 pci_read_config8(pci_devfn_t dev, unsigned int where);</span><br><span> u16 pci_read_config16(pci_devfn_t dev, unsigned int where);</span><br><span> u32 pci_read_config32(pci_devfn_t dev, unsigned int where);</span><br><span>diff --git a/src/arch/x86/include/arch/io.h b/src/arch/x86/include/arch/io.h</span><br><span>index 1b0fdb0..f47973e 100644</span><br><span>--- a/src/arch/x86/include/arch/io.h</span><br><span>+++ b/src/arch/x86/include/arch/io.h</span><br><span>@@ -18,8 +18,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <rules.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* FIXME: Sources for romstage still use device_t. */</span><br><span style="color: hsl(0, 100%, 40%);">-/* Use pci_devfn_t or pnp_devfn_t instead */</span><br><span> typedef u32 pci_devfn_t;</span><br><span> typedef u32 pnp_devfn_t;</span><br><span> </span><br><span>@@ -256,10 +254,6 @@</span><br><span> </span><br><span> #define PNP_DEV(PORT, FUNC) (((PORT) << 8) | (FUNC))</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* FIXME: Sources for romstage still use device_t. */</span><br><span style="color: hsl(0, 100%, 40%);">-/* Use pci_devfn_t or pnp_devfn_t instead */</span><br><span style="color: hsl(0, 100%, 40%);">-typedef u32 device_t;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* FIXME: We need to make the coreboot to run at 64bit mode, So when read/write</span><br><span> * memory above 4G, We don't need to set %fs, and %gs anymore</span><br><span> * Before that We need to use %gs, and leave %fs to other RAM access</span><br><span>diff --git a/src/device/pci_early.c b/src/device/pci_early.c</span><br><span>index 6baebe0..ff481bc 100644</span><br><span>--- a/src/device/pci_early.c</span><br><span>+++ b/src/device/pci_early.c</span><br><span>@@ -13,14 +13,12 @@</span><br><span> * GNU General Public License for more details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define __SIMPLE_DEVICE__</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #include <arch/io.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <delay.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#ifdef __PRE_RAM__</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> unsigned pci_find_next_capability(pci_devfn_t dev, unsigned cap, unsigned last)</span><br><span> {</span><br><span> unsigned pos = 0;</span><br><span>@@ -68,12 +66,16 @@</span><br><span> {</span><br><span> return pci_find_next_capability(dev, cap, 0);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* __PRE_RAM__ */</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* __SIMPLE_DEVICE__ */</span><br><span> </span><br><span> </span><br><span> #if IS_ENABLED(CONFIG_EARLY_PCI_BRIDGE)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void pci_bridge_reset_secondary(device_t p2p_bridge)</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+static void pci_bridge_reset_secondary(pci_devfn_t p2p_bridge)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static void pci_bridge_reset_secondary(struct device *p2p_bridge)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u16 reg16;</span><br><span> </span><br><span>@@ -90,7 +92,11 @@</span><br><span> pci_write_config16(p2p_bridge, PCI_BRIDGE_CONTROL, reg16);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void pci_bridge_set_secondary(device_t p2p_bridge, u8 secondary)</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+static void pci_bridge_set_secondary(pci_devfn_t p2p_bridge, u8 secondary)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static void pci_bridge_set_secondary(struct device *p2p_bridge, u8 secondary)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> /* Disable config transaction forwarding. */</span><br><span> pci_write_config8(p2p_bridge, PCI_SECONDARY_BUS, 0x00);</span><br><span>@@ -100,7 +106,11 @@</span><br><span> pci_write_config8(p2p_bridge, PCI_SUBORDINATE_BUS, secondary);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void pci_bridge_set_mmio(device_t p2p_bridge, u32 base, u32 size)</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+static void pci_bridge_set_mmio(pci_devfn_t p2p_bridge, u32 base, u32 size)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static void pci_bridge_set_mmio(struct device *p2p_bridge, u32 base, u32 size)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u16 reg16;</span><br><span> </span><br><span>diff --git a/src/include/device/device.h b/src/include/device/device.h</span><br><span>index 6713c94..c2f8ece 100644</span><br><span>--- a/src/include/device/device.h</span><br><span>+++ b/src/include/device/device.h</span><br><span>@@ -14,14 +14,9 @@</span><br><span> #include <rules.h></span><br><span> #include <device/resource.h></span><br><span> #include <device/path.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct device;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#ifndef __SIMPLE_DEVICE__</span><br><span style="color: hsl(0, 100%, 40%);">-typedef struct device *device_t;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> #include <arch/io.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+struct device;</span><br><span> struct pci_operations;</span><br><span> struct pci_bus_operations;</span><br><span> struct i2c_bus_operations;</span><br><span>diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h</span><br><span>index 5e60e8d..54284f5 100644</span><br><span>--- a/src/include/device/pci_ops.h</span><br><span>+++ b/src/include/device/pci_ops.h</span><br><span>@@ -15,33 +15,49 @@</span><br><span> </span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * Use device_t here as the functions are to be used with either</span><br><span style="color: hsl(0, 100%, 40%);">- * __SIMPLE_DEVICE__ defined or undefined.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> static __always_inline</span><br><span style="color: hsl(0, 100%, 40%);">-void pci_or_config8(device_t dev, unsigned int where, u8 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_or_config8(pci_devfn_t dev, unsigned int where, u8 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static __always_inline</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_or_config8(struct device *dev, unsigned int where, u8 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u8 value = pci_read_config8(dev, where);</span><br><span> pci_write_config8(dev, where, value | ormask);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> static __always_inline</span><br><span style="color: hsl(0, 100%, 40%);">-void pci_or_config16(device_t dev, unsigned int where, u16 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_or_config16(pci_devfn_t dev, unsigned int where, u16 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static __always_inline</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_or_config16(struct device *dev, unsigned int where, u16 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u16 value = pci_read_config16(dev, where);</span><br><span> pci_write_config16(dev, where, value | ormask);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> static __always_inline</span><br><span style="color: hsl(0, 100%, 40%);">-void pci_or_config32(device_t dev, unsigned int where, u32 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_or_config32(pci_devfn_t dev, unsigned int where, u32 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static __always_inline</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_or_config32(struct device *dev, unsigned int where, u32 ormask)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u32 value = pci_read_config32(dev, where);</span><br><span> pci_write_config32(dev, where, value | ormask);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> static __always_inline</span><br><span style="color: hsl(0, 100%, 40%);">-void pci_update_config8(device_t dev, int reg, u8 mask, u8 or)</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_update_config8(pci_devfn_t dev, int reg, u8 mask, u8 or)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static __always_inline</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_update_config8(struct device *dev, int reg, u8 mask, u8 or)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u8 reg8;</span><br><span> </span><br><span>@@ -51,8 +67,13 @@</span><br><span> pci_write_config8(dev, reg, reg8);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> static __always_inline</span><br><span style="color: hsl(0, 100%, 40%);">-void pci_update_config16(device_t dev, int reg, u16 mask, u16 or)</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_update_config16(pci_devfn_t dev, int reg, u16 mask, u16 or)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static __always_inline</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_update_config16(struct device *dev, int reg, u16 mask, u16 or)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u16 reg16;</span><br><span> </span><br><span>@@ -62,8 +83,13 @@</span><br><span> pci_write_config16(dev, reg, reg16);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> static __always_inline</span><br><span style="color: hsl(0, 100%, 40%);">-void pci_update_config32(device_t dev, int reg, u32 mask, u32 or)</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_update_config32(pci_devfn_t dev, int reg, u32 mask, u32 or)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static __always_inline</span><br><span style="color: hsl(120, 100%, 40%);">+void pci_update_config32(struct device *dev, int reg, u32 mask, u32 or)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> u32 reg32;</span><br><span> </span><br><span>diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h</span><br><span>index 639e938..621300d 100644</span><br><span>--- a/src/include/device/smbus.h</span><br><span>+++ b/src/include/device/smbus.h</span><br><span>@@ -51,9 +51,13 @@</span><br><span> return i2c_dev_writeb_at(dev, addr, val);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer);</span><br><span style="color: hsl(0, 100%, 40%);">-int smbus_block_write(device_t dev, u8 cmd, u8 bytes, const u8 *buffer);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+int smbus_block_read(pci_devfn_t dev, u8 cmd, u8 bytes, u8 *buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+int smbus_block_write(pci_devfn_t dev, u8 cmd, u8 bytes, const u8 *buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+int smbus_block_read(struct device *dev, u8 cmd, u8 bytes, u8 *buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+int smbus_block_write(struct device *dev, u8 cmd, u8 bytes, const u8 *buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> #if IS_ENABLED(CONFIG_SMBUS_HAS_AUX_CHANNELS)</span><br><span> void smbus_switch_to_channel(uint8_t channel_number);</span><br><span> uint8_t smbus_get_current_channel(void);</span><br><span>diff --git a/src/include/reg_script.h b/src/include/reg_script.h</span><br><span>index 116dd92..28fc82d 100644</span><br><span>--- a/src/include/reg_script.h</span><br><span>+++ b/src/include/reg_script.h</span><br><span>@@ -30,8 +30,6 @@</span><br><span> * are employed:</span><br><span> * - Chaining of tables that allow runtime tables to chain to compile-time</span><br><span> * tables.</span><br><span style="color: hsl(0, 100%, 40%);">- * - Notion of current device (device_t) being worked on. This allows for</span><br><span style="color: hsl(0, 100%, 40%);">- * PCI config, io, and mmio on a particular device's resources.</span><br><span> *</span><br><span> * Note that when using REG_SCRIPT_COMMAND_NEXT there is an implicit push</span><br><span> * and pop of the context. A chained reg_script inherits the previous</span><br><span>@@ -87,13 +85,21 @@</span><br><span> union {</span><br><span> uint32_t id;</span><br><span> const struct reg_script *next;</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+ pci_devfn_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> unsigned int res_index;</span><br><span> };</span><br><span> };</span><br><span> </span><br><span> struct reg_script_context {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+ pci_devfn_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> struct resource *res;</span><br><span> const struct reg_script *step;</span><br><span> uint8_t display_state; /* Only modified by reg_script_run_step */</span><br><span>@@ -437,6 +443,10 @@</span><br><span> _REG_SCRIPT_ENCODE_RAW(REG_SCRIPT_COMMAND_END, 0, 0, 0, 0, 0, 0, 0)</span><br><span> </span><br><span> void reg_script_run(const struct reg_script *script);</span><br><span style="color: hsl(0, 100%, 40%);">-void reg_script_run_on_dev(device_t dev, const struct reg_script *step);</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+void reg_script_run_on_dev(pci_devfn_t dev, const struct reg_script *step);</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+void reg_script_run_on_dev(struct device *dev, const struct reg_script *step);</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> </span><br><span> #endif /* REG_SCRIPT_H */</span><br><span>diff --git a/src/lib/reg_script.c b/src/lib/reg_script.c</span><br><span>index e84c137..926a659 100644</span><br><span>--- a/src/lib/reg_script.c</span><br><span>+++ b/src/lib/reg_script.c</span><br><span>@@ -40,8 +40,13 @@</span><br><span> #define EMPTY_DEV NULL</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span> static inline void reg_script_set_dev(struct reg_script_context *ctx,</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+ pci_devfn_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static inline void reg_script_set_dev(struct reg_script_context *ctx,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> ctx->dev = dev;</span><br><span> ctx->res = NULL;</span><br><span>@@ -677,7 +682,11 @@</span><br><span> reg_script_run_with_context(&ctx);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void reg_script_run_on_dev(device_t dev, const struct reg_script *step)</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+void reg_script_run_on_dev(pci_devfn_t dev, const struct reg_script *step)</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+void reg_script_run_on_dev(struct device *dev, const struct reg_script *step)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> {</span><br><span> struct reg_script_context ctx;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30047">change 30047</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30047"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie05869901ac33d7089e21110f46c1241f7ee731f </div>
<div style="display:none"> Gerrit-Change-Number: 30047 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>