<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30069">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/sarien: Set initial I2C bus rise/fall times<br><br>Provide rise/fall times as measured on existing boards.  This will<br>need adjusted for new boards but provides a starting point that<br>makes I2C clocks look reasonable.<br><br>Tested by measuring I2C bus speed and rise/fall times with a scope.<br><br>Change-Id: Ic18010f5efc41dcee8925d696767ba2c44e3df4b<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/mainboard/google/sarien/variants/arcada/devicetree.cb<br>M src/mainboard/google/sarien/variants/sarien/devicetree.cb<br>2 files changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/30069/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb</span><br><span>index f487979..54308e1 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb</span><br><span>+++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb</span><br><span>@@ -67,10 +67,14 @@</span><br><span>           },</span><br><span>           .i2c[1] = {</span><br><span>                  .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+                      .rise_time_ns = 216,</span><br><span style="color: hsl(120, 100%, 40%);">+                  .fall_time_ns = 28,</span><br><span>          },</span><br><span>           .i2c[4] = {</span><br><span>                  .early_init = 1,</span><br><span>                     .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+                      .rise_time_ns = 452,</span><br><span style="color: hsl(120, 100%, 40%);">+                  .fall_time_ns = 110,</span><br><span>                 },</span><br><span>   }"</span><br><span> </span><br><span>diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb</span><br><span>index 991e9640..e1f2512 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb</span><br><span>+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb</span><br><span>@@ -67,10 +67,14 @@</span><br><span>          },</span><br><span>           .i2c[1] = {</span><br><span>                  .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+                      .rise_time_ns = 290,</span><br><span style="color: hsl(120, 100%, 40%);">+                  .fall_time_ns = 110,</span><br><span>                 },</span><br><span>           .i2c[4] = {</span><br><span>                  .early_init = 1,</span><br><span>                     .speed = I2C_SPEED_FAST,</span><br><span style="color: hsl(120, 100%, 40%);">+                      .rise_time_ns = 280,</span><br><span style="color: hsl(120, 100%, 40%);">+                  .fall_time_ns = 90,</span><br><span>          },</span><br><span>   }"</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30069">change 30069</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30069"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic18010f5efc41dcee8925d696767ba2c44e3df4b </div>
<div style="display:none"> Gerrit-Change-Number: 30069 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>