<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30036">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/wilco: Guard DTPF with ifdef<br><br>There is a dependency issue with the EC DPTF code accessing<br>methods that are external, but once the mainboard includes the<br>relevant code they become internal and the current version of<br>IASL used by jenkins will fail to compile it.<br><br>Until the new IASL is deployed everywhere wrap the EC DPTF code<br>and expect that the mainboard will explicitly enable it.<br><br>Change-Id: I612ad8f86d424060ca0303d267d7c2915c760173<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/ec/google/wilco/acpi/dptf.asl<br>M src/ec/google/wilco/acpi/ec.asl<br>M src/ec/google/wilco/acpi/event.asl<br>3 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/30036/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/wilco/acpi/dptf.asl b/src/ec/google/wilco/acpi/dptf.asl</span><br><span>index f5545d0..0f1663f 100644</span><br><span>--- a/src/ec/google/wilco/acpi/dptf.asl</span><br><span>+++ b/src/ec/google/wilco/acpi/dptf.asl</span><br><span>@@ -18,10 +18,6 @@</span><br><span>  * Dynamic Platform Thermal Framework support</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-External (\_SB.DPTF.CTOK, MethodObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_SB.DPTF.KTOC, MethodObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_SB.DPTF.TEVT, MethodObj)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Mutex for EC PAT interface */</span><br><span> Mutex (PATM, 1)</span><br><span> </span><br><span>diff --git a/src/ec/google/wilco/acpi/ec.asl b/src/ec/google/wilco/acpi/ec.asl</span><br><span>index ff8fccc..f9b16b5 100644</span><br><span>--- a/src/ec/google/wilco/acpi/ec.asl</span><br><span>+++ b/src/ec/google/wilco/acpi/ec.asl</span><br><span>@@ -147,5 +147,7 @@</span><br><span>    #include "event.asl"</span><br><span>       #include "lid.asl"</span><br><span>         #include "platform.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef EC_ENABLE_DPTF</span><br><span>     #include "dptf.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> }</span><br><span>diff --git a/src/ec/google/wilco/acpi/event.asl b/src/ec/google/wilco/acpi/event.asl</span><br><span>index 21721f2..4a3394f 100644</span><br><span>--- a/src/ec/google/wilco/acpi/event.asl</span><br><span>+++ b/src/ec/google/wilco/acpi/event.asl</span><br><span>@@ -88,10 +88,12 @@</span><br><span> {</span><br><span>   Printf ("EVT3: %o", Arg0)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef EC_ENABLE_DPTF</span><br><span>       /* Theraml Events */</span><br><span>         If (EBIT (E3TH, Arg0)) {</span><br><span>             ^PATX ()</span><br><span>     }</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> }</span><br><span> </span><br><span> /* Handle events in PmEv4 */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30036">change 30036</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30036"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I612ad8f86d424060ca0303d267d7c2915c760173 </div>
<div style="display:none"> Gerrit-Change-Number: 30036 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>