<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29757">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common/dptf: Make CPU address a define<br><br>In order to support using the common ACPI code on more platforms<br>than just Apollo Lake the DPTF code needs to be told what the<br>PCI address is for the CPU thermal device.<br><br>Change-Id: I638f2387330bbc42f64eb0fb676ee32c5df6572e<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>Reviewed-on: https://review.coreboot.org/c/29757<br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/soc/intel/apollolake/acpi/dptf.asl<br>M src/soc/intel/common/acpi/dptf/cpu.asl<br>2 files changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/acpi/dptf.asl b/src/soc/intel/apollolake/acpi/dptf.asl</span><br><span>index b9ba9c3..f34725f 100644</span><br><span>--- a/src/soc/intel/apollolake/acpi/dptf.asl</span><br><span>+++ b/src/soc/intel/apollolake/acpi/dptf.asl</span><br><span>@@ -14,6 +14,7 @@</span><br><span>  */</span><br><span> </span><br><span> #define DPTF_CPU_DEVICE              TCPU</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_CPU_ADDR             0x00000001</span><br><span> </span><br><span> #ifndef DPTF_CPU_PASSIVE</span><br><span> #define DPTF_CPU_PASSIVE  80</span><br><span>diff --git a/src/soc/intel/common/acpi/dptf/cpu.asl b/src/soc/intel/common/acpi/dptf/cpu.asl</span><br><span>index c28c0cc..9414e25 100644</span><br><span>--- a/src/soc/intel/common/acpi/dptf/cpu.asl</span><br><span>+++ b/src/soc/intel/common/acpi/dptf/cpu.asl</span><br><span>@@ -23,7 +23,7 @@</span><br><span> </span><br><span> Device (DPTF_CPU_DEVICE)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        Name(_ADR, 0x00000001)</span><br><span style="color: hsl(120, 100%, 40%);">+        Name(_ADR, DPTF_CPU_ADDR)</span><br><span> </span><br><span>        Method (_STA)</span><br><span>        {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29757">change 29757</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29757"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I638f2387330bbc42f64eb0fb676ee32c5df6572e </div>
<div style="display:none"> Gerrit-Change-Number: 29757 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>