<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29673">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/wilco: Enable WiFi radio<br><br>Add EC command to enable WiFi radio and send that command at<br>startup. Tested to ensure WiFi is functional on a sarien board.<br><br>Change-Id: Iac46895c7118567e1eb55ea33051a1662103b563<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>Reviewed-on: https://review.coreboot.org/c/29673<br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/ec/google/wilco/chip.c<br>M src/ec/google/wilco/commands.c<br>M src/ec/google/wilco/commands.h<br>3 files changed, 26 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c</span><br><span>index 0cd0048..e1f468d 100644</span><br><span>--- a/src/ec/google/wilco/chip.c</span><br><span>+++ b/src/ec/google/wilco/chip.c</span><br><span>@@ -66,6 +66,9 @@</span><br><span> </span><br><span> /* Unmute speakers */</span><br><span> wilco_ec_send(KB_HW_MUTE_CONTROL, AUDIO_UNMUTE_125MS);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Enable WiFi radio */</span><br><span style="color: hsl(120, 100%, 40%);">+ wilco_ec_radio_control(RADIO_WIFI, 1);</span><br><span> }</span><br><span> </span><br><span> static void wilco_ec_resource(struct device *dev, int index,</span><br><span>diff --git a/src/ec/google/wilco/commands.c b/src/ec/google/wilco/commands.c</span><br><span>index 1767a01..c42699d 100644</span><br><span>--- a/src/ec/google/wilco/commands.c</span><br><span>+++ b/src/ec/google/wilco/commands.c</span><br><span>@@ -149,3 +149,12 @@</span><br><span> KB_POWER_OFF, &reason, 1, NULL, 0) < 0)</span><br><span> printk(BIOS_ERR, "%s: command failed\n", __func__);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int wilco_ec_radio_control(enum ec_radio radio, uint8_t state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t radio_control[3] = { 0, radio, state };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return wilco_ec_mailbox(WILCO_EC_MSG_DEFAULT, KB_RADIO_CONTROL,</span><br><span style="color: hsl(120, 100%, 40%);">+ radio_control, ARRAY_SIZE(radio_control),</span><br><span style="color: hsl(120, 100%, 40%);">+ NULL, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h</span><br><span>index 4a19030..0989b20 100644</span><br><span>--- a/src/ec/google/wilco/commands.h</span><br><span>+++ b/src/ec/google/wilco/commands.h</span><br><span>@@ -26,6 +26,8 @@</span><br><span> KB_POWER_STATUS = 0x05,</span><br><span> /* Inform the EC aboout the reason host is turning off */</span><br><span> KB_POWER_OFF = 0x08,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Control wireless radios */</span><br><span style="color: hsl(120, 100%, 40%);">+ KB_RADIO_CONTROL = 0x2b,</span><br><span> /* Save PS/2 data before S3 suspend */</span><br><span> KB_SAVE = 0x2f,</span><br><span> /* Restore PS/2 data after S3 resume */</span><br><span>@@ -61,6 +63,18 @@</span><br><span> AUDIO_UNMUTE_125MS, /* Unmute in 125ms */</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+enum ec_radio {</span><br><span style="color: hsl(120, 100%, 40%);">+ RADIO_WIFI = 0x02,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/**</span><br><span style="color: hsl(120, 100%, 40%);">+ * wilco_ec_radio_control() - Control wireless radios.</span><br><span style="color: hsl(120, 100%, 40%);">+ * @ec_radio: Wireless radio type.</span><br><span style="color: hsl(120, 100%, 40%);">+ * @state: Turn radio on or off.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Return: 0 if successful or negative error code on failure.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+int wilco_ec_radio_control(enum ec_radio radio, uint8_t state);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*</span><br><span> * EC Information</span><br><span> */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29673">change 29673</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29673"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iac46895c7118567e1eb55ea33051a1662103b563 </div>
<div style="display:none"> Gerrit-Change-Number: 29673 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>