<p>Philipp Deppenwiese <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30014">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  David Hendricks: Looks good to me, approved
  Philipp Deppenwiese: Looks good to me, approved
  Julius Werner: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/spi/winbond: Fix TB bit<br><br>The TB has to be inverted to actually protected the correct region.<br><br>Tested on elgon using I67eb4ee8e0ad297a8d1984d55102146688c291fc.<br><br>Change-Id: I715791b8ae5d1db1ef587321ae5c9daa10eb7dbc<br>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com><br>Reviewed-on: https://review.coreboot.org/c/30014<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com><br>Reviewed-by: David Hendricks <david.hendricks@gmail.com><br>Reviewed-by: Julius Werner <jwerner@chromium.org><br>---<br>M src/drivers/spi/winbond.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c</span><br><span>index 9eb3352..f8ea247 100644</span><br><span>--- a/src/drivers/spi/winbond.c</span><br><span>+++ b/src/drivers/spi/winbond.c</span><br><span>@@ -303,7 +303,7 @@</span><br><span>              tb = !tb;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   out->offset = tb ? flash_size - protected_size : 0;</span><br><span style="color: hsl(120, 100%, 40%);">+        out->offset = tb ? 0 : flash_size - protected_size;</span><br><span>       out->size = protected_size;</span><br><span> }</span><br><span> </span><br><span>@@ -519,9 +519,9 @@</span><br><span>        wp_region = *region;</span><br><span> </span><br><span>     if (region_offset(&wp_region) == 0)</span><br><span style="color: hsl(0, 100%, 40%);">-         tb = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- else</span><br><span>                 tb = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+       else</span><br><span style="color: hsl(120, 100%, 40%);">+          tb = 0;</span><br><span> </span><br><span>  if (region_sz(&wp_region) > flash->size / 2) {</span><br><span>             cmp = 1;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30014">change 30014</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30014"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I715791b8ae5d1db1ef587321ae5c9daa10eb7dbc </div>
<div style="display:none"> Gerrit-Change-Number: 30014 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>