<p>Patch set 15:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://review.coreboot.org/c/coreboot/+/29917">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c">File src/cpu/amd/family_10h-family_15h/init_cpus.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c@1062">Patch Set #15, Line 1062:</a> <code style="font-family:monospace,monospace">!!</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">not needed</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">are you sure?<br>I'm fine with removing this, but it was used this way (and it is also used at line #1076).<br>I believe, that the Author know that (!!x = x), so if he used !!nvram, maybe there is a reason.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/pineview/early_init.c">File src/northbridge/intel/pineview/early_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/pineview/early_init.c@123">Patch Set #15, Line 123:</a> <code style="font-family:monospace,monospace">     u32 reg32;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">is it me or is reg32 not needed at all?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't know if that register needs a read before a write ...<br>in fact, I didn't find the datasheet :(</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/x4x/early_init.c">File src/northbridge/intel/x4x/early_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/x4x/early_init.c@a243">Patch Set #15, Line 243:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">is it needed to read reg16 over DIMBAR32 here ?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage/romstage.c">File src/soc/intel/fsp_baytrail/romstage/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage/romstage.c@253">Patch Set #15, Line 253:</a> <code style="font-family:monospace,monospace">cbmem_was_initted</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Do we need this variable? I would call cbmem_recovery inside here instead.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are right, but that will be some "crowded" <br>Usually, we don't put an instruction inside the is "condition".</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/romstage/romstage.c">File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/romstage/romstage.c@119">Patch Set #15, Line 119:</a> <code style="font-family:monospace,monospace">cbmem_was_initted</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oops, it shoild be '!cbmem_was_initted'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/romstage.c">File src/southbridge/intel/fsp_rangeley/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/romstage.c@122">Patch Set #15, Line 122:</a> <code style="font-family:monospace,monospace">cbmem_was_initted</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">sould be "!cbmem_was_initted"</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29917">change 29917</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29917"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 </div>
<div style="display:none"> Gerrit-Change-Number: 29917 </div>
<div style="display:none"> Gerrit-PatchSet: 15 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Damien Zammit <damien@zamaudio.com> </div>
<div style="display:none"> Gerrit-Reviewer: David Guckian <david.guckian@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Huang Jin <huang.jin@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: York Yang <york.yang@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 03 Dec 2018 07:28:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>