<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29988">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Duncan Laurie: Looks good to me, approved
Furquan Shaikh: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variant/nocturne: increase touch panel power-on delay<br><br>The WACOM 5C01 touch panel power-up delay of 10mS is too aggressive<br>and causes "failed to change power setting" errors in the kernel, so<br>this change increases the power-up delay to 20mS which allows enough<br>time for the WACOM device's i2c controller to wake up.<br><br>BUG=b:120090384<br>BRANCH=none<br>TEST=flash and boot nocturne, log into kernel, execute the following<br>command and make sure the string is not found :<br> dmesg | grep "failed to change power setting"<br><br>Change-Id: I1db0b3f5ce666b79d8ada2939ec865233ce52a56<br>Signed-off-by: Nick Vaccaro <nvaccaro@google.com><br>Reviewed-on: https://review.coreboot.org/c/29988<br>Reviewed-by: Duncan Laurie <dlaurie@chromium.org><br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 1786502..031c7ff 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -320,7 +320,7 @@</span><br><span> register "generic.speed" = "I2C_SPEED_FAST_PLUS"</span><br><span> register "generic.probed" = "1"</span><br><span> register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E11)"</span><br><span style="color: hsl(0, 100%, 40%);">- register "generic.reset_delay_ms" = "10"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "generic.reset_delay_ms" = "20"</span><br><span> register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"</span><br><span> register "generic.enable_delay_ms" = "1"</span><br><span> register "generic.has_power_resource" = "1"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29988">change 29988</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29988"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1db0b3f5ce666b79d8ada2939ec865233ce52a56 </div>
<div style="display:none"> Gerrit-Change-Number: 29988 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>