<p style="white-space: pre-wrap; word-wrap: break-word;">I feel there are some variables that could be removed completely instead of putting assignments to make them seem used.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29917">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c">File src/cpu/amd/family_10h-family_15h/init_cpus.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c@1062">Patch Set #15, Line 1062:</a> <code style="font-family:monospace,monospace">!!</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">not needed</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/pineview/early_init.c">File src/northbridge/intel/pineview/early_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/pineview/early_init.c@123">Patch Set #15, Line 123:</a> <code style="font-family:monospace,monospace">    u32 reg32;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">is it me or is reg32 not needed at all?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/x4x/early_init.c">File src/northbridge/intel/x4x/early_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/x4x/early_init.c@226">Patch Set #15, Line 226:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">reg16 = RCBA16(0x1a8);<br>     reg16 &= ~0x3;<br>    RCBA16(0x1a8) = reg16;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">What do we need reg16 for?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage/romstage.c">File src/soc/intel/fsp_baytrail/romstage/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage/romstage.c@253">Patch Set #15, Line 253:</a> <code style="font-family:monospace,monospace">cbmem_was_initted</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we need this variable? I would call cbmem_recovery inside here instead.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/romstage/romstage.c">File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/romstage/romstage.c@119">Patch Set #15, Line 119:</a> <code style="font-family:monospace,monospace">cbmem_was_initted</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/romstage.c">File src/southbridge/intel/fsp_rangeley/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/romstage.c@122">Patch Set #15, Line 122:</a> <code style="font-family:monospace,monospace">cbmem_was_initted</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29917">change 29917</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29917"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 </div>
<div style="display:none"> Gerrit-Change-Number: 29917 </div>
<div style="display:none"> Gerrit-PatchSet: 15 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Damien Zammit <damien@zamaudio.com> </div>
<div style="display:none"> Gerrit-Reviewer: David Guckian <david.guckian@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Huang Jin <huang.jin@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: York Yang <york.yang@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 02 Dec 2018 21:51:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>