<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30008">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common/block/pcr: Don't use device_t<br><br>Use of device_t is deprecated.<br><br>Change-Id: I9d7f1bc22d960d93173760c1bfe4db2dd9277967<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/soc/intel/common/block/pcr/pcr.c<br>1 file changed, 18 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/30008/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/pcr/pcr.c b/src/soc/intel/common/block/pcr/pcr.c</span><br><span>index 58eb13a..57b2c2b 100644</span><br><span>--- a/src/soc/intel/common/block/pcr/pcr.c</span><br><span>+++ b/src/soc/intel/common/block/pcr/pcr.c</span><br><span>@@ -220,20 +220,35 @@</span><br><span> }</span><br><span> </span><br><span> #if !IS_ENABLED(CONFIG_PCR_COMMON_IOSF_1_0)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static int pcr_wait_for_completion(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef __SIMPLE_DEVICE__</span><br><span style="color: hsl(120, 100%, 40%);">+static int pcr_wait_for_completion(pci_devfn_t dev)</span><br><span> {</span><br><span>  struct stopwatch sw;</span><br><span> </span><br><span>     stopwatch_init_msecs_expire(&sw, PCR_SBI_CMD_TIMEOUT);</span><br><span>   do {</span><br><span>                 if ((pci_read_config16(dev, P2SB_CR_SBI_STATUS) &</span><br><span style="color: hsl(0, 100%, 40%);">-                   P2SB_CR_SBI_STATUS_BUSY) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                     P2SB_CR_SBI_STATUS_BUSY) == 0)</span><br><span>                  return 0;</span><br><span>    } while (!stopwatch_expired(&sw));</span><br><span> </span><br><span>   return -1;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+static int pcr_wait_for_completion(struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     struct stopwatch sw;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        stopwatch_init_msecs_expire(&sw, PCR_SBI_CMD_TIMEOUT);</span><br><span style="color: hsl(120, 100%, 40%);">+    do {</span><br><span style="color: hsl(120, 100%, 40%);">+          if ((pci_read_config16(dev, P2SB_CR_SBI_STATUS) &</span><br><span style="color: hsl(120, 100%, 40%);">+              P2SB_CR_SBI_STATUS_BUSY) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                   return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     } while (!stopwatch_expired(&sw));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* __SIMPLE_DEVICE__ */</span><br><span> </span><br><span> /*</span><br><span>  * API to perform sideband communication</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30008">change 30008</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30008"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9d7f1bc22d960d93173760c1bfe4db2dd9277967 </div>
<div style="display:none"> Gerrit-Change-Number: 30008 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>