<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30000">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/sarien: Define USB devices for ACPI<br><br>Add the USB device information for the sarien/arcada variants.<br>This includes the ACPI _PLD group definitions for the external<br>ports that indicate which USB2 and USB3 ports share the same<br>physical interface.<br><br>Change-Id: I0b936127954ba09c61ccb871bfc62ee7d99da263<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/mainboard/google/sarien/Kconfig<br>M src/mainboard/google/sarien/variants/arcada/devicetree.cb<br>M src/mainboard/google/sarien/variants/sarien/devicetree.cb<br>3 files changed, 181 insertions(+), 22 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/30000/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig</span><br><span>index 9b4696b..c9e4c0b 100644</span><br><span>--- a/src/mainboard/google/sarien/Kconfig</span><br><span>+++ b/src/mainboard/google/sarien/Kconfig</span><br><span>@@ -6,6 +6,7 @@</span><br><span> select DRIVERS_I2C_HID</span><br><span> select DRIVERS_SPI_ACPI</span><br><span> select DRIVERS_PS2_KEYBOARD</span><br><span style="color: hsl(120, 100%, 40%);">+ select DRIVERS_USB_ACPI</span><br><span> select EC_GOOGLE_WILCO</span><br><span> select GENERIC_SPD_BIN</span><br><span> select HAVE_ACPI_RESUME</span><br><span>diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb</span><br><span>index 4bd2d90..f487979 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb</span><br><span>+++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb</span><br><span>@@ -33,21 +33,21 @@</span><br><span> register "dptf_enable" = "1"</span><br><span> </span><br><span> # Intel Common SoC Config</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Type-C</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[1]" = "USB2_PORT_LONG(OC0)" # Ext USB2 Port 3</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[2]" = "USB2_PORT_LONG(OC1)" # Ext USB2 Port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Left Type-C Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[1]" = "USB2_PORT_LONG(OC0)" # Left Type-A Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[2]" = "USB2_PORT_LONG(OC1)" # Right Type-A Port</span><br><span> register "usb2_ports[3]" = "USB2_PORT_EMPTY"</span><br><span> register "usb2_ports[4]" = "USB2_PORT_EMPTY"</span><br><span> register "usb2_ports[5]" = "USB2_PORT_LONG(OC_SKIP)" # Camera</span><br><span> register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WWAN</span><br><span> register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # USH</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # FPR in PB</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # M.2 2230 (BT)</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # Fingerprint</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-C</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC0)" # Ext USB3 Port 3</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC1)" # Ext USB3 Port 4</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # M.2 3042 (WWAN)</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Left Type-C Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC0)" # Left Type-A Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC1)" # Right Type-A Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # WWAN</span><br><span> register "usb3_ports[4]" = "USB3_PORT_EMPTY"</span><br><span> register "usb3_ports[5]" = "USB3_PORT_EMPTY"</span><br><span> </span><br><span>@@ -109,7 +109,80 @@</span><br><span> device pci 12.0 on end # Thermal Subsystem</span><br><span> device pci 12.5 off end # UFS SCS</span><br><span> device pci 12.6 off end # GSPI #2</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 14.0 on end # USB xHCI</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 14.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Root Hub""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_HUB"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 0.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-C Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-A Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 2)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.1 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Right Type-A Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(2, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.2 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Camera""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.5 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""WWAN""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.6 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USH""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.7 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Fingerprint""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.8 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Bluetooth""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.9 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-C Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-A Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_USB3_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 2)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.1 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Right Type-A Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_USB3_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(2, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.2 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""WWAN""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.3 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end # USB xHCI</span><br><span> device pci 14.1 off end # USB xDCI (OTG)</span><br><span> chip drivers/intel/wifi</span><br><span> register "wake" = "PME_B0_EN_BIT"</span><br><span>diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb</span><br><span>index 66f1711..4696d7f 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb</span><br><span>+++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb</span><br><span>@@ -33,22 +33,22 @@</span><br><span> register "dptf_enable" = "1"</span><br><span> </span><br><span> # Intel Common SoC Config</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Type-C</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[1]" = "USB2_PORT_LONG(OC0)" # Ext USB2 Port 1 Charge</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[2]" = "USB2_PORT_LONG(OC1)" # Ext USB2 Port 2</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[3]" = "USB2_PORT_LONG(OC2)" # Ext USB2 Port 3</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Left Type-C Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[1]" = "USB2_PORT_LONG(OC0)" # Right Type-A Port 1</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[2]" = "USB2_PORT_LONG(OC1)" # Left Type-A Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[3]" = "USB2_PORT_LONG(OC2)" # Right Type-A Port 2</span><br><span> register "usb2_ports[4]" = "USB2_PORT_EMPTY"</span><br><span> register "usb2_ports[5]" = "USB2_PORT_LONG(OC_SKIP)" # Camera</span><br><span> register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WWAN</span><br><span> register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # USH</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # FPR in PB</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # M.2 2230 (BT)</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # Fingerprint</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-C</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC0)" # Ext USB3 Port 1 Charge</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC1)" # Ext USB3 Port 2</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC2)" # Ext USB3 Port 3</span><br><span style="color: hsl(0, 100%, 40%);">- register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC_SKIP)" # M.2 3042 (WWAN)</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Left Type-C Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC0)" # Right Type-A Port 1</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC1)" # Left Type-A Port</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC2)" # Right Type-A Port 2</span><br><span style="color: hsl(120, 100%, 40%);">+ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC_SKIP)" # WWAN</span><br><span> register "usb3_ports[5]" = "USB3_PORT_EMPTY"</span><br><span> </span><br><span> # Intel Common SoC Config</span><br><span>@@ -109,7 +109,92 @@</span><br><span> device pci 12.0 on end # Thermal Subsystem</span><br><span> device pci 12.5 off end # UFS SCS</span><br><span> device pci 12.6 off end # GSPI #2</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 14.0 on end # USB xHCI</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 14.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Root Hub""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_HUB"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 0.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-C Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Right Type-A Port 1""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(2, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.1 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-A Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 2)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.2 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Right Type-A Port 2""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(2, 2)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.4 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Camera""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.5 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""WWAN""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.6 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""USH""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.7 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Fingerprint""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.8 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Bluetooth""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 2.9 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-C Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Right Type-A Port 1""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_USB3_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(2, 1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.1 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Left Type-A Port""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_USB3_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(1, 2)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.2 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""Right Type-A Port 2""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_USB3_A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "group" = "ACPI_PLD_GROUP(2, 2)"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.3 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ chip drivers/usb/acpi</span><br><span style="color: hsl(120, 100%, 40%);">+ register "desc" = ""WWAN""</span><br><span style="color: hsl(120, 100%, 40%);">+ register "type" = "UPC_TYPE_INTERNAL"</span><br><span style="color: hsl(120, 100%, 40%);">+ device usb 3.4 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end</span><br><span style="color: hsl(120, 100%, 40%);">+ end # USB xHCI</span><br><span> device pci 14.1 off end # USB xDCI (OTG)</span><br><span> chip drivers/intel/wifi</span><br><span> register "wake" = "PME_B0_EN_BIT"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30000">change 30000</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30000"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b936127954ba09c61ccb871bfc62ee7d99da263 </div>
<div style="display:none"> Gerrit-Change-Number: 30000 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>