<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30001">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Enable mode change as wake source from S3/S0ix<br><br>This change enables mode change as a wake source from S3 and<br>S0ix. Thus, any time the device switches between clamshell and tablet<br>mode while it is suspended, it will be treated as a valid user event<br>and hence wake source.<br><br>BUG=b:120349473<br>BRANCH=octopus<br>TEST=Verified that octopus wakes up on mode transitions.<br><br>Change-Id: Ib224df434730f873ce5514303e5d043cbc85a9a4<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h<br>1 file changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/30001/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h</span><br><span>index 3398875..d416673 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h</span><br><span>+++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/ec.h</span><br><span>@@ -43,10 +43,17 @@</span><br><span>         (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN)     |\</span><br><span>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* EC can wake from S3 with lid or power button or key press */</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * EC can wake from S3/S0ix with:</span><br><span style="color: hsl(120, 100%, 40%);">+ * 1. Lid open</span><br><span style="color: hsl(120, 100%, 40%);">+ * 2. Power button</span><br><span style="color: hsl(120, 100%, 40%);">+ * 3. Key press</span><br><span style="color: hsl(120, 100%, 40%);">+ * 4. Mode change</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> #define MAINBOARD_EC_S3_WAKE_EVENTS \</span><br><span>     (MAINBOARD_EC_S5_WAKE_EVENTS |\</span><br><span style="color: hsl(0, 100%, 40%);">-  EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED))</span><br><span style="color: hsl(120, 100%, 40%);">+        EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\</span><br><span style="color: hsl(120, 100%, 40%);">+      EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))</span><br><span> </span><br><span> #define MAINBOARD_EC_S0IX_WAKE_EVENTS    (MAINBOARD_EC_S3_WAKE_EVENTS)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30001">change 30001</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30001"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib224df434730f873ce5514303e5d043cbc85a9a4 </div>
<div style="display:none"> Gerrit-Change-Number: 30001 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>