<p><a href="https://review.coreboot.org/c/coreboot/+/29968">View Change</a></p><p>95 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/clock.c">File src/soc/qualcomm/qcs405/clock.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/clock.c@206">Patch Set #2, Line 206:</a> <code style="font-family:monospace,monospace"> clock_enable_vote(REG(GCC_BLSP1_AHB_CBCR),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/clock.c@206">Patch Set #2, Line 206:</a> <code style="font-family:monospace,monospace"> clock_enable_vote(REG(GCC_BLSP1_AHB_CBCR),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/clock.c@207">Patch Set #2, Line 207:</a> <code style="font-family:monospace,monospace"> REG(GCC_APCS_CLOCK_BRANCH_ENA_VOTE),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/clock.c@207">Patch Set #2, Line 207:</a> <code style="font-family:monospace,monospace"> REG(GCC_APCS_CLOCK_BRANCH_ENA_VOTE),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/clock.c@208">Patch Set #2, Line 208:</a> <code style="font-family:monospace,monospace"> BLSP2_AHB_CLK_ENA);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/clock.c@208">Patch Set #2, Line 208:</a> <code style="font-family:monospace,monospace"> BLSP2_AHB_CLK_ENA);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/include/soc/qup.h">File src/soc/qualcomm/qcs405/include/soc/qup.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/include/soc/qup.h@161">Patch Set #2, Line 161:</a> <code style="font-family:monospace,monospace"> unsigned clk_frequency;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/include/soc/qup.h@162">Patch Set #2, Line 162:</a> <code style="font-family:monospace,monospace"> unsigned src_frequency;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/include/soc/qup.h@164">Patch Set #2, Line 164:</a> <code style="font-family:monospace,monospace"> unsigned initialized;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/include/soc/qup.h@173">Patch Set #2, Line 173:</a> <code style="font-family:monospace,monospace"> unsigned data_len;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/include/soc/qup.h@178">Patch Set #2, Line 178:</a> <code style="font-family:monospace,monospace"> unsigned size;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c">File src/soc/qualcomm/qcs405/spi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@63">Patch Set #2, Line 63:</a> <code style="font-family:monospace,monospace"> {0},{0},{0},{0},</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@63">Patch Set #2, Line 63:</a> <code style="font-family:monospace,monospace"> {0},{0},{0},{0},</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@63">Patch Set #2, Line 63:</a> <code style="font-family:monospace,monospace"> {0},{0},{0},{0},</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@64">Patch Set #2, Line 64:</a> <code style="font-family:monospace,monospace"> /* BLSP5 registers for SPI interface */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@65">Patch Set #2, Line 65:</a> <code style="font-family:monospace,monospace"> {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@65">Patch Set #2, Line 65:</a> <code style="font-family:monospace,monospace"> {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@66">Patch Set #2, Line 66:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_CONFIG_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@66">Patch Set #2, Line 66:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_CONFIG_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@67">Patch Set #2, Line 67:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_IO_CONTROL_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@67">Patch Set #2, Line 67:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_IO_CONTROL_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@68">Patch Set #2, Line 68:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_ERROR_FLAGS_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@68">Patch Set #2, Line 68:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_ERROR_FLAGS_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@69">Patch Set #2, Line 69:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_ERROR_FLAGS_EN_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@69">Patch Set #2, Line 69:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_ERROR_FLAGS_EN_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@70">Patch Set #2, Line 70:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_CONFIG_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@70">Patch Set #2, Line 70:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_CONFIG_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@71">Patch Set #2, Line 71:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_ERROR_FLAGS_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@71">Patch Set #2, Line 71:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_ERROR_FLAGS_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@72">Patch Set #2, Line 72:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_ERROR_FLAGS_EN_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@72">Patch Set #2, Line 72:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_ERROR_FLAGS_EN_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@73">Patch Set #2, Line 73:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_OPERATIONAL_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@73">Patch Set #2, Line 73:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_OPERATIONAL_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@74">Patch Set #2, Line 74:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_IO_MODES_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@74">Patch Set #2, Line 74:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_IO_MODES_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@75">Patch Set #2, Line 75:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_STATE_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@75">Patch Set #2, Line 75:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_STATE_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@76">Patch Set #2, Line 76:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_INPUT_FIFOc_REG(0),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@76">Patch Set #2, Line 76:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_INPUT_FIFOc_REG(0),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@77">Patch Set #2, Line 77:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_OUTPUT_FIFOc_REG(0),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@77">Patch Set #2, Line 77:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_OUTPUT_FIFOc_REG(0),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@78">Patch Set #2, Line 78:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_MX_INPUT_COUNT_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@78">Patch Set #2, Line 78:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_MX_INPUT_COUNT_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@79">Patch Set #2, Line 79:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_MX_OUTPUT_COUNT_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@79">Patch Set #2, Line 79:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_MX_OUTPUT_COUNT_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@80">Patch Set #2, Line 80:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_SW_RESET_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@80">Patch Set #2, Line 80:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_SW_RESET_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@81">Patch Set #2, Line 81:</a> <code style="font-family:monospace,monospace"> 0,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@81">Patch Set #2, Line 81:</a> <code style="font-family:monospace,monospace"> 0,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@82">Patch Set #2, Line 82:</a> <code style="font-family:monospace,monospace"> 0,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@82">Patch Set #2, Line 82:</a> <code style="font-family:monospace,monospace"> 0,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@83">Patch Set #2, Line 83:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_OPERATIONAL_MASK,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@83">Patch Set #2, Line 83:</a> <code style="font-family:monospace,monospace"> BLSP5_QUP_OPERATIONAL_MASK,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@84">Patch Set #2, Line 84:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_DEASSERT_WAIT_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@84">Patch Set #2, Line 84:</a> <code style="font-family:monospace,monospace"> BLSP5_SPI_DEASSERT_WAIT_REG,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@85">Patch Set #2, Line 85:</a> <code style="font-family:monospace,monospace"> },</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@85">Patch Set #2, Line 85:</a> <code style="font-family:monospace,monospace"> },</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@273">Patch Set #2, Line 273:</a> <code style="font-family:monospace,monospace"> SPI_IO_CTRL_NO_TRI_STATE | SPI_IO_CTRL_MX_CS_MODE);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@310">Patch Set #2, Line 310:</a> <code style="font-family:monospace,monospace"> switch(slave->bus) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">switch and case should be at the same indent</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@310">Patch Set #2, Line 310:</a> <code style="font-family:monospace,monospace"> switch(slave->bus) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@311">Patch Set #2, Line 311:</a> <code style="font-family:monospace,monospace"> case 5:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@311">Patch Set #2, Line 311:</a> <code style="font-family:monospace,monospace"> case 5:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@313">Patch Set #2, Line 313:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@313">Patch Set #2, Line 313:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@313">Patch Set #2, Line 313:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@314">Patch Set #2, Line 314:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@314">Patch Set #2, Line 314:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@314">Patch Set #2, Line 314:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@315">Patch Set #2, Line 315:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@315">Patch Set #2, Line 315:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@315">Patch Set #2, Line 315:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@316">Patch Set #2, Line 316:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@316">Patch Set #2, Line 316:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@316">Patch Set #2, Line 316:</a> <code style="font-family:monospace,monospace"> gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@318">Patch Set #2, Line 318:</a> <code style="font-family:monospace,monospace"> break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@318">Patch Set #2, Line 318:</a> <code style="font-family:monospace,monospace"> break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@319">Patch Set #2, Line 319:</a> <code style="font-family:monospace,monospace"> default:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@320">Patch Set #2, Line 320:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "SPI error: unsupported bus %d (Supported busses 0, 1, 2, 3, 4, 5) ", slave->bus);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@320">Patch Set #2, Line 320:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "SPI error: unsupported bus %d (Supported busses 0, 1, 2, 3, 4, 5) ", slave->bus);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@320">Patch Set #2, Line 320:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "SPI error: unsupported bus %d (Supported busses 0, 1, 2, 3, 4, 5) ", slave->bus);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@321">Patch Set #2, Line 321:</a> <code style="font-family:monospace,monospace"> break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@321">Patch Set #2, Line 321:</a> <code style="font-family:monospace,monospace"> break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@322">Patch Set #2, Line 322:</a> <code style="font-family:monospace,monospace"> }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@322">Patch Set #2, Line 322:</a> <code style="font-family:monospace,monospace"> }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@354">Patch Set #2, Line 354:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">void function return statements are not generally useful</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@428">Patch Set #2, Line 428:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">void function return statements are not generally useful</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@684">Patch Set #2, Line 684:</a> <code style="font-family:monospace,monospace"> "or chipselect\n", bus);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@684">Patch Set #2, Line 684:</a> <code style="font-family:monospace,monospace"> "or chipselect\n", bus);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@713">Patch Set #2, Line 713:</a> <code style="font-family:monospace,monospace">static int xfer_vectors(const struct spi_slave *slave,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">open brace '{' following function definitions go on the next line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@714">Patch Set #2, Line 714:</a> <code style="font-family:monospace,monospace"> struct spi_op vectors[], size_t count)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@714">Patch Set #2, Line 714:</a> <code style="font-family:monospace,monospace"> struct spi_op vectors[], size_t count)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@715">Patch Set #2, Line 715:</a> <code style="font-family:monospace,monospace"> {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@716">Patch Set #2, Line 716:</a> <code style="font-family:monospace,monospace"> return spi_flash_vector_helper(slave, vectors, count, spi_ctrlr_xfer);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@716">Patch Set #2, Line 716:</a> <code style="font-family:monospace,monospace"> return spi_flash_vector_helper(slave, vectors, count, spi_ctrlr_xfer);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29968/2/src/soc/qualcomm/qcs405/spi.c@717">Patch Set #2, Line 717:</a> <code style="font-family:monospace,monospace"> }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29968">change 29968</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29968"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I340eb3bf77b25fe3502d4b29ef4bf7c06b282c02 </div>
<div style="display:none"> Gerrit-Change-Number: 29968 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Nov 2018 14:08:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>