<p>nsekar@codeaurora.org has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29961">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">qcs405: Enable uart_bit_bang<br><br>uart_bit_bang has been enabled for VER, ROM, RAM stages.<br>uart_fill_lb() empty routine has been declared to avoid<br>compilation error.<br><br>Change-Id: I387779a74913ffb58d74d2f2c5d3e22167bbc310<br>Signed-off-by: Sricharan R <sricharan@codeaurora.org><br>Signed-off-by: Nitheesh Sekar <nsekar@codeaurora.org><br>---<br>M src/soc/qualcomm/qcs405/Makefile.inc<br>M src/soc/qualcomm/qcs405/uart_bitbang.c<br>2 files changed, 14 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/29961/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/qualcomm/qcs405/Makefile.inc b/src/soc/qualcomm/qcs405/Makefile.inc</span><br><span>index 17ba0f1..6fc87c7 100644</span><br><span>--- a/src/soc/qualcomm/qcs405/Makefile.inc</span><br><span>+++ b/src/soc/qualcomm/qcs405/Makefile.inc</span><br><span>@@ -14,6 +14,7 @@</span><br><span> verstage-y += spi.c</span><br><span> verstage-y += timer.c</span><br><span> verstage-y += gpio.c</span><br><span style="color: hsl(120, 100%, 40%);">+verstage-$(CONFIG_DRIVERS_UART) += uart_bitbang.c</span><br><span> verstage-$(CONFIG_QC_SOC_SIMULATE) += flash_controller.c</span><br><span> </span><br><span> ################################################################################</span><br><span>@@ -21,6 +22,8 @@</span><br><span> romstage-y += cbmem.c</span><br><span> romstage-y += timer.c</span><br><span> romstage-y += gpio.c</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-y += mmu.c</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-$(CONFIG_DRIVERS_UART) += uart_bitbang.c</span><br><span> romstage-$(CONFIG_QC_SOC_SIMULATE) += flash_controller.c</span><br><span> </span><br><span> ################################################################################</span><br><span>@@ -29,6 +32,7 @@</span><br><span> ramstage-y += cbmem.c</span><br><span> ramstage-y += timer.c</span><br><span> ramstage-y += gpio.c</span><br><span style="color: hsl(120, 100%, 40%);">+ramstage-$(CONFIG_DRIVERS_UART) += uart_bitbang.c</span><br><span> ramstage-$(CONFIG_QC_SOC_SIMULATE) += flash_controller.c</span><br><span> </span><br><span> ################################################################################</span><br><span>diff --git a/src/soc/qualcomm/qcs405/uart_bitbang.c b/src/soc/qualcomm/qcs405/uart_bitbang.c</span><br><span>index 8827bc4..97782bd 100644</span><br><span>--- a/src/soc/qualcomm/qcs405/uart_bitbang.c</span><br><span>+++ b/src/soc/qualcomm/qcs405/uart_bitbang.c</span><br><span>@@ -19,6 +19,8 @@</span><br><span> </span><br><span> #define UART_TX_PIN GPIO(17)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void uart_fill_lb(void *data);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void set_tx(int line_state)</span><br><span> {</span><br><span>    gpio_set(UART_TX_PIN, line_state);</span><br><span>@@ -43,3 +45,11 @@</span><br><span> {</span><br><span>         return 0;       /* not implemented */</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+//HACK</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef __PRE_RAM__</span><br><span style="color: hsl(120, 100%, 40%);">+/* TODO: Implement function */</span><br><span style="color: hsl(120, 100%, 40%);">+void uart_fill_lb(void *data)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29961">change 29961</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29961"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I387779a74913ffb58d74d2f2c5d3e22167bbc310 </div>
<div style="display:none"> Gerrit-Change-Number: 29961 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>