<p><a href="https://review.coreboot.org/c/coreboot/+/29959">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/flash_controller.c">File src/soc/qualcomm/qcs405/flash_controller.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/flash_controller.c@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace">static int ram_read(const struct spi_flash *flash, u32 addr, size_t len, void *buf)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/flash_controller.c@68">Patch Set #1, Line 68:</a> <code style="font-family:monospace,monospace">{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that open brace { should be on the previous line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/flash_controller.c@78">Patch Set #1, Line 78:</a> <code style="font-family:monospace,monospace">     static char name[] = "ram_flash";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">static char array declaration should probably be static const char</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/flash_controller.c@80">Patch Set #1, Line 80:</a> <code style="font-family:monospace,monospace">    printk(BIOS_INFO, "[%s]..CONFIG_QC_SOC_SIMULATE\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/flash_controller.c@82">Patch Set #1, Line 82:</a> <code style="font-family:monospace,monospace"> printk(BIOS_INFO, "[%s]..ram_flash\n", __FUNCTION__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">__func__ should be used instead of gcc specific __FUNCTION__</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/mmu.c">File src/soc/qualcomm/qcs405/mmu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29959/1/src/soc/qualcomm/qcs405/mmu.c@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace">        mmu_config_range((void *)0x80000000, 0x40000000, MA_MEM | MA_NS | MA_RW);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29959">change 29959</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29959"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I895315a995cbbd5e6a7a305e48476f0d0f583cfe </div>
<div style="display:none"> Gerrit-Change-Number: 29959 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: nsekar@codeaurora.org </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Nov 2018 10:15:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>