<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29925">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/gm45: Make fetching the blc_pwm freq global<br><br>This can be used to select the proper VBT.<br><br>Change-Id: Id3f6ba3ae31a5ab47f44d207678c1c4a6a43b7ec<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/gm45/gm45.h<br>M src/northbridge/intel/gm45/gma.c<br>2 files changed, 8 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/29925/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/gm45/gm45.h b/src/northbridge/intel/gm45/gm45.h</span><br><span>index 95863d9..37e1ddc 100644</span><br><span>--- a/src/northbridge/intel/gm45/gm45.h</span><br><span>+++ b/src/northbridge/intel/gm45/gm45.h</span><br><span>@@ -443,6 +443,7 @@</span><br><span>     int pwm_freq; /* In Hz */</span><br><span> };</span><br><span> int get_blc_values(const struct blc_pwm_t **entries);</span><br><span style="color: hsl(120, 100%, 40%);">+int get_blc_pwm_freq_value(void);</span><br><span> </span><br><span> </span><br><span> #if ENV_RAMSTAGE && !defined(__SIMPLE_DEVICE__)</span><br><span>diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c</span><br><span>index 34cf367..511225f 100644</span><br><span>--- a/src/northbridge/intel/gm45/gma.c</span><br><span>+++ b/src/northbridge/intel/gm45/gma.c</span><br><span>@@ -41,6 +41,8 @@</span><br><span> </span><br><span> static struct resource *gtt_res = NULL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+char edid_ascii_string[EDID_ASCII_STRING_LENGTH + 1];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> u32 gtt_read(u32 reg)</span><br><span> {</span><br><span>    return read32(res2mmio(gtt_res, reg, 0));</span><br><span>@@ -668,7 +670,7 @@</span><br><span>              return (blc_mod << 16) | blc_mod;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int get_blc_pwm_freq_value(const char *edid_ascii_string)</span><br><span style="color: hsl(120, 100%, 40%);">+int get_blc_pwm_freq_value(void)</span><br><span> {</span><br><span>      static int blc_pwm_freq = -1;</span><br><span>        const struct blc_pwm_t *blc_pwm;</span><br><span>@@ -701,8 +703,7 @@</span><br><span>       return blc_pwm_freq;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_pm_init_post_vbios(struct device *const dev,</span><br><span style="color: hsl(0, 100%, 40%);">-                               const char *edid_ascii_string)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_pm_init_post_vbios(struct device *const dev)</span><br><span> {</span><br><span>    const struct northbridge_intel_gm45_config *const conf = dev->chip_info;</span><br><span> </span><br><span>@@ -739,7 +740,7 @@</span><br><span>        reg8 = 100;</span><br><span>  if (conf->duty_cycle != 0)</span><br><span>                reg8 = conf->duty_cycle;</span><br><span style="color: hsl(0, 100%, 40%);">-     pwm_freq = get_blc_pwm_freq_value(edid_ascii_string);</span><br><span style="color: hsl(120, 100%, 40%);">+ pwm_freq = get_blc_pwm_freq_value();</span><br><span>         if (pwm_freq < 0 && conf->default_pwm_freq != 0)</span><br><span>               pwm_freq = conf->default_pwm_freq;</span><br><span> </span><br><span>@@ -780,7 +781,8 @@</span><br><span>      decode_edid(edid_data_lvds, sizeof(edid_data_lvds), &edid_lvds);</span><br><span> </span><br><span>     /* Post VBIOS init */</span><br><span style="color: hsl(0, 100%, 40%);">-   gma_pm_init_post_vbios(dev, edid_lvds.ascii_string);</span><br><span style="color: hsl(120, 100%, 40%);">+  memcpy(edid_ascii_string, edid_lvds.ascii_string, sizeof(edid_ascii_string));</span><br><span style="color: hsl(120, 100%, 40%);">+ gma_pm_init_post_vbios(dev);</span><br><span> </span><br><span>     int vga_disable = (pci_read_config16(dev, D0F0_GGC) & 2) >> 1;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29925">change 29925</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29925"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id3f6ba3ae31a5ab47f44d207678c1c4a6a43b7ec </div>
<div style="display:none"> Gerrit-Change-Number: 29925 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>