<p>Aamir Bohra has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29883">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/intel/icelake_rvp: Add camera acpi support<br><br>This implementation adds acpi camera support for below sensors:<br><br>1. SONY319A: User facing camera interfaced to SOC over i2c2<br>2. SONY355A: World facing camera interfaced to SOC over i2c3<br><br>Change-Id: Ic70cc944ebbbe7784550a643f115d39ecbf989e9<br>Signed-off-by: Aamir Bohra <aamir.bohra@intel.com><br>---<br>M src/mainboard/intel/icelake_rvp/Kconfig<br>A src/mainboard/intel/icelake_rvp/acpi/cam0.asl<br>A src/mainboard/intel/icelake_rvp/acpi/cam1.asl<br>A src/mainboard/intel/icelake_rvp/acpi/camera.asl<br>M src/mainboard/intel/icelake_rvp/acpi/mainboard.asl<br>M src/mainboard/intel/icelake_rvp/dsdt.asl<br>6 files changed, 243 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/29883/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/intel/icelake_rvp/Kconfig b/src/mainboard/intel/icelake_rvp/Kconfig</span><br><span>index 0741bf8..bf7f855 100644</span><br><span>--- a/src/mainboard/intel/icelake_rvp/Kconfig</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/Kconfig</span><br><span>@@ -7,6 +7,7 @@</span><br><span> select HAVE_ACPI_RESUME</span><br><span> select HAVE_ACPI_TABLES</span><br><span> select MAINBOARD_HAS_CHROMEOS</span><br><span style="color: hsl(120, 100%, 40%);">+ select MAINBOARD_HAS_CAMERA_ACPI</span><br><span> select GENERIC_SPD_BIN</span><br><span> select DRIVERS_I2C_HID</span><br><span> select DRIVERS_I2C_GENERIC</span><br><span>@@ -35,6 +36,12 @@</span><br><span> string</span><br><span> default "Intel_icelake_rvp"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config MAINBOARD_HAS_CAMERA_ACPI</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default n</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Select this option to enable camera ACPI support.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> config MAX_CPUS</span><br><span> int</span><br><span> default 8</span><br><span>diff --git a/src/mainboard/intel/icelake_rvp/acpi/cam0.asl b/src/mainboard/intel/icelake_rvp/acpi/cam0.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..ba0c16e</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/acpi/cam0.asl</span><br><span>@@ -0,0 +1,120 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Intel Corp.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Scope (\_SB.PCI0.I2C3)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (CAM0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_HID, "SONY355A") /* _HID: Hardware ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x0F)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_CRS, ResourceTemplate ()</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x001A, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Port0 of CAM0 is connected to port0 of CIO2 device */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DSD, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "port0", "PRT0" },</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "clock-frequency", 19200000 }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (PRT0, Package() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "port", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "endpoint0", "EP00" },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (EP00, Package() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "endpoint", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "clock-lanes", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "data-lanes",</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { 1, 2, 3, 4 }</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "link-frequencies",</span><br><span style="color: hsl(120, 100%, 40%);">+ Package() { 1190400000, 640000000 }</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (SSDB, 0, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Buffer (0x5E)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0000 */ 0x00, 0x50, 0x00, 0x00, 0x00, 0x00,0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0028 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0030 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0038 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0040 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0048 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x08, 0x03,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0050 */ 0x09, 0x00, 0x02, 0x01, 0x00, 0x01, 0x00, 0x36,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0058 */ 0x6E, 0x01, 0x00, 0x00, 0x00, 0x00</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (VCM0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_HID, "PRP0001") /* _HID: Hardware ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x0F)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_CRS, ResourceTemplate ()</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DSD, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "compatible", "asahi-kasei,ak7375" },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>\ No newline at end of file</span><br><span>diff --git a/src/mainboard/intel/icelake_rvp/acpi/cam1.asl b/src/mainboard/intel/icelake_rvp/acpi/cam1.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..d67cec9</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/acpi/cam1.asl</span><br><span>@@ -0,0 +1,94 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Intel Corp.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Scope (\_SB.PCI0.I2C2)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (CAM1)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_HID, "SONY319A") /* _HID: Hardware ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x0F)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_CRS, ResourceTemplate ()</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C2",</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Port0 of CAM1 is connected to port1 of CIO2 device */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DSD, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "port0", "PRT0" },</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "clock-frequency", 19200000 },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (PRT0, Package() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "port", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "endpoint0", "EP00" },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (EP00, Package() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "endpoint", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "clock-lanes", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "data-lanes",</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { 1, 2, 3, 4 }</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "link-frequencies",</span><br><span style="color: hsl(120, 100%, 40%);">+ Package() { 844800000 }</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (SSDB, 0, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Buffer (0x5E)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0000 */ 0x00, 0x50, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x01, 0x02, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0028 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0030 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0038 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0040 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0048 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x08, 0x03,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0050 */ 0x09, 0x00, 0x02, 0x01, 0x00, 0x01, 0x00, 0x36,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 0058 */ 0x6E, 0x01, 0x00, 0x00, 0x00, 0x00</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>\ No newline at end of file</span><br><span>diff --git a/src/mainboard/intel/icelake_rvp/acpi/camera.asl b/src/mainboard/intel/icelake_rvp/acpi/camera.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..81d54f8</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/acpi/camera.asl</span><br><span>@@ -0,0 +1,17 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Intel Corp.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include "cam0.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "cam1.asl"</span><br><span>diff --git a/src/mainboard/intel/icelake_rvp/acpi/mainboard.asl b/src/mainboard/intel/icelake_rvp/acpi/mainboard.asl</span><br><span>index 49ae2e6..80064b3 100644</span><br><span>--- a/src/mainboard/intel/icelake_rvp/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/acpi/mainboard.asl</span><br><span>@@ -22,3 +22,7 @@</span><br><span> }</span><br><span> }</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_MAINBOARD_HAS_CAMERA_ACPI)</span><br><span style="color: hsl(120, 100%, 40%);">+ #include "camera.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>\ No newline at end of file</span><br><span>diff --git a/src/mainboard/intel/icelake_rvp/dsdt.asl b/src/mainboard/intel/icelake_rvp/dsdt.asl</span><br><span>index c15f80c..85efe4d 100644</span><br><span>--- a/src/mainboard/intel/icelake_rvp/dsdt.asl</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/dsdt.asl</span><br><span>@@ -40,6 +40,7 @@</span><br><span> {</span><br><span> #include <soc/intel/icelake/acpi/northbridge.asl></span><br><span> #include <soc/intel/icelake/acpi/southbridge.asl></span><br><span style="color: hsl(120, 100%, 40%);">+ #include <soc/intel/icelake/acpi/ipu.asl></span><br><span> }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29883">change 29883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29883"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic70cc944ebbbe7784550a643f115d39ecbf989e9 </div>
<div style="display:none"> Gerrit-Change-Number: 29883 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>