<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29904">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP]mb/intel/x200: Add data.vbt<br><br>There are 2 vendor BIOS's for the Lenovo X200 with the difference being the<br>settings in the VBT blob to accommodate different backlight frequencies.<br>Linux however sticks with the setting set by the firmware.<br><br>Change-Id: I4c4a7011ce03cdd511fa2e2160c2f006ba2707ba<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/lenovo/x200/Kconfig<br>M src/mainboard/lenovo/x200/Makefile.inc<br>M src/mainboard/lenovo/x200/blc.c<br>A src/mainboard/lenovo/x200/data_ccfl.vbt<br>A src/mainboard/lenovo/x200/data_led.vbt<br>5 files changed, 51 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29904/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig</span><br><span>index 51a08e8..6aa2f9b 100644</span><br><span>--- a/src/mainboard/lenovo/x200/Kconfig</span><br><span>+++ b/src/mainboard/lenovo/x200/Kconfig</span><br><span>@@ -22,6 +22,7 @@</span><br><span> select SUPERIO_NSC_PC87382</span><br><span> select DRIVERS_LENOVO_WACOM</span><br><span> select MAINBOARD_HAS_LIBGFXINIT</span><br><span style="color: hsl(120, 100%, 40%);">+# select INTEL_GMA_HAVE_VBT</span><br><span> </span><br><span> config MAINBOARD_DIR</span><br><span> string</span><br><span>diff --git a/src/mainboard/lenovo/x200/Makefile.inc b/src/mainboard/lenovo/x200/Makefile.inc</span><br><span>index c10bc70..3a86aa7 100644</span><br><span>--- a/src/mainboard/lenovo/x200/Makefile.inc</span><br><span>+++ b/src/mainboard/lenovo/x200/Makefile.inc</span><br><span>@@ -19,3 +19,12 @@</span><br><span> romstage-y += gpio.c</span><br><span> </span><br><span> ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+add_vbt_to_cbfs= \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(eval cbfs-files-y += $1) \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(eval $1-file := $2) \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(eval $1-type := raw) \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(eval $1-compression := lzma)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+$(call add_vbt_to_cbfs, data_ccfl.vbt, data_ccfl.vbt)</span><br><span style="color: hsl(120, 100%, 40%);">+$(call add_vbt_to_cbfs, data_led.vbt, data_led.vbt)</span><br><span>\ No newline at end of file</span><br><span>diff --git a/src/mainboard/lenovo/x200/blc.c b/src/mainboard/lenovo/x200/blc.c</span><br><span>index 3f8aadb..e764602 100644</span><br><span>--- a/src/mainboard/lenovo/x200/blc.c</span><br><span>+++ b/src/mainboard/lenovo/x200/blc.c</span><br><span>@@ -13,9 +13,14 @@</span><br><span> * GNU General Public License for more details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/pci_ops.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/pci_def.h></span><br><span> #include <stdint.h></span><br><span> #include <commonlib/helpers.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <console/console.h></span><br><span> #include <northbridge/intel/gm45/gm45.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <drivers/intel/gma/i915_reg.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <drivers/intel/gma/opregion.h></span><br><span> </span><br><span> static const struct blc_pwm_t blc_entries[] = {</span><br><span> /* corrected to 320MHz CDClk, vendor set 753; works fine at both: */</span><br><span>@@ -43,3 +48,39 @@</span><br><span> *entries = blc_entries;</span><br><span> return ARRAY_SIZE(blc_entries);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 get_cdclk(struct device *const dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const u16 cdclk_sel =</span><br><span style="color: hsl(120, 100%, 40%);">+ pci_read_config16(dev, GCFGC_OFFSET) & GCFGC_CD_MASK;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (MCHBAR8(HPLLVCO_MCHBAR) & 0x7) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case VCO_2666:</span><br><span style="color: hsl(120, 100%, 40%);">+ case VCO_4000:</span><br><span style="color: hsl(120, 100%, 40%);">+ case VCO_5333:</span><br><span style="color: hsl(120, 100%, 40%);">+ return cdclk_sel ? 333333333 : 222222222;</span><br><span style="color: hsl(120, 100%, 40%);">+ case VCO_3200:</span><br><span style="color: hsl(120, 100%, 40%);">+ return cdclk_sel ? 320000000 : 228571429;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_WARNING,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Unknown VCO frequency, using default cdclk.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return 222222222;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 blc_pwm_ctl_to_freq(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = dev_find_slot(0, PCI_DEVFN(2, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ u8 *mmio_base = (void *)(uintptr_t)dev->resource_list[0].base;</span><br><span style="color: hsl(120, 100%, 40%);">+ u32 blc_pwm_ctl = read32(mmio_base + BLC_PWM_CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return get_cdclk(dev) / (128 * (blc_pwm_ctl & 0xffff));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const char *mainboard_vbt_filename(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ if (blc_pwm_ctl_to_freq() > 200)</span><br><span style="color: hsl(120, 100%, 40%);">+ return "data_led.vbt";</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ return "data_ccfl.vbt";</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/mainboard/lenovo/x200/data_ccfl.vbt b/src/mainboard/lenovo/x200/data_ccfl.vbt</span><br><span>new file mode 100644</span><br><span>index 0000000..dc044c9</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/lenovo/x200/data_ccfl.vbt</span><br><span>Binary files differ</span><br><span>diff --git a/src/mainboard/lenovo/x200/data_led.vbt b/src/mainboard/lenovo/x200/data_led.vbt</span><br><span>new file mode 100644</span><br><span>index 0000000..bcd6c30</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/lenovo/x200/data_led.vbt</span><br><span>Binary files differ</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29904">change 29904</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29904"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4c4a7011ce03cdd511fa2e2160c2f006ba2707ba </div>
<div style="display:none"> Gerrit-Change-Number: 29904 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>