<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29887">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cpu/intel/fsp_model_406dx: Rework acpi/cpu.asl<br><br>Change-Id: I00d15d0640a37f89ffd5cc87b89d5ba11fecb9ed<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/cpu/intel/fsp_model_406dx/acpi.c<br>M src/cpu/intel/fsp_model_406dx/acpi/cpu.asl<br>2 files changed, 23 insertions(+), 67 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/29887/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/cpu/intel/fsp_model_406dx/acpi.c b/src/cpu/intel/fsp_model_406dx/acpi.c</span><br><span>index 80a56c0..b1f212e 100644</span><br><span>--- a/src/cpu/intel/fsp_model_406dx/acpi.c</span><br><span>+++ b/src/cpu/intel/fsp_model_406dx/acpi.c</span><br><span>@@ -295,6 +295,23 @@</span><br><span> acpigen_pop_len();</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* PPKG is usually used for thermal management</span><br><span style="color: hsl(120, 100%, 40%);">+ of the first and only package. */</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_processor_package("PPKG", 0, cores_per_package);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Add a method to notify processor nodes */</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_method("\\_PR.CNOT", 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ for (coreID = 0; coreID < cores_per_package; coreID++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ char buffer[DEVICE_PATH_MAX];</span><br><span style="color: hsl(120, 100%, 40%);">+ snprintf(buffer, sizeof(buffer), "\\_PR.CP%c%c",</span><br><span style="color: hsl(120, 100%, 40%);">+ '0' + coreID / 10, '0' + coreID % 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_emit_byte(NOTIFY_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_emit_namestring(buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_emit_byte(ARG0_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_pop_len();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> }</span><br><span> </span><br><span> struct chip_operations cpu_intel_model_406dx_ops = {</span><br><span>diff --git a/src/cpu/intel/fsp_model_406dx/acpi/cpu.asl b/src/cpu/intel/fsp_model_406dx/acpi/cpu.asl</span><br><span>index a95c54a..3ee5265 100644</span><br><span>--- a/src/cpu/intel/fsp_model_406dx/acpi/cpu.asl</span><br><span>+++ b/src/cpu/intel/fsp_model_406dx/acpi/cpu.asl</span><br><span>@@ -14,84 +14,23 @@</span><br><span> * GNU General Public License for more details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* These devices are created at runtime */</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP00, DeviceObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP01, DeviceObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP02, DeviceObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP03, DeviceObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP04, DeviceObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP05, DeviceObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP06, DeviceObj)</span><br><span style="color: hsl(0, 100%, 40%);">-External (\_PR.CP07, DeviceObj)</span><br><span style="color: hsl(120, 100%, 40%);">+/* These come from the dynamically created CPU SSDT */</span><br><span style="color: hsl(120, 100%, 40%);">+External (\_PR.CNOT, MethodObj)</span><br><span> </span><br><span> /* Notify OS to re-read CPU tables, assuming ^2 CPU count */</span><br><span> Method (PNOT)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 2)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP00, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP01, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 4)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP02, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP03, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 8)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP04, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP05, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP06, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP07, 0x81) // _CST</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ \_PR.CNOT (0x81)</span><br><span> }</span><br><span> </span><br><span> /* Notify OS to re-read CPU _PPC limit, assuming ^2 CPU count */</span><br><span> Method (PPCN)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 2)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP00, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP01, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 4)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP02, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP03, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 8)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP04, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP05, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP06, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP07, 0x80) // _PPC</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ \_PR.CNOT (0x81)</span><br><span> }</span><br><span> </span><br><span> /* Notify OS to re-read Throttle Limit tables, assuming ^2 CPU count */</span><br><span> Method (TNOT)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 2)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP00, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP01, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 4)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP02, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP03, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 8)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP04, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP05, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP06, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_PR.CP07, 0x82) // _TPC</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Return a package containing enabled processor entries */</span><br><span style="color: hsl(0, 100%, 40%);">-Method (PPKG)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreaterEqual (\PCNT, 8)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (Package() {\_PR.CP00, \_PR.CP01, \_PR.CP02, \_PR.CP03,</span><br><span style="color: hsl(0, 100%, 40%);">- \_PR.CP04, \_PR.CP05, \_PR.CP06, \_PR.CP07})</span><br><span style="color: hsl(0, 100%, 40%);">- } ElseIf (LGreaterEqual (\PCNT, 4)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (Package() {\_PR.CP00, \_PR.CP01, \_PR.CP02, \_PR.CP03})</span><br><span style="color: hsl(0, 100%, 40%);">- } ElseIf (LGreaterEqual (\PCNT, 2)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (Package() {\_PR.CP00, \_PR.CP01})</span><br><span style="color: hsl(0, 100%, 40%);">- } Else {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (Package() {\_PR.CP00})</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(120, 100%, 40%);">+ \_PR.CNOT (0x82)</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>\ No newline at end of file</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29887">change 29887</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29887"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00d15d0640a37f89ffd5cc87b89d5ba11fecb9ed </div>
<div style="display:none"> Gerrit-Change-Number: 29887 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>