<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29853">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">{mb,nb,soc/fsp_baytrail}: Get rid of dump_mem()<br><br>Use hexdump() instead of dump_mem().<br><br>Change-Id: I7f6431bb2903a0d06f8ed0ada93aa3231a58eb6f<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/amd/mahogany_fam10/romstage.c<br>M src/mainboard/asus/m4a78-em/romstage.c<br>M src/mainboard/asus/m4a785-m/romstage.c<br>M src/mainboard/asus/m5a88-v/romstage.c<br>M src/mainboard/gigabyte/ma785gm/romstage.c<br>M src/mainboard/gigabyte/ma785gmt/romstage.c<br>M src/mainboard/iei/kino-780am2-fam10/romstage.c<br>M src/mainboard/jetway/pa78vm5/romstage.c<br>M src/mainboard/supermicro/h8scm_fam10/romstage.c<br>M src/northbridge/amd/amdfam10/debug.c<br>M src/northbridge/amd/amdfam10/debug.h<br>M src/northbridge/intel/e7505/debug.c<br>M src/northbridge/intel/e7505/debug.h<br>M src/northbridge/intel/fsp_rangeley/northbridge.h<br>M src/northbridge/intel/haswell/haswell.h<br>M src/northbridge/intel/i945/debug.c<br>M src/northbridge/intel/i945/i945.h<br>M src/northbridge/intel/nehalem/nehalem.h<br>M src/northbridge/intel/sandybridge/sandybridge.h<br>M src/soc/intel/fsp_baytrail/include/soc/baytrail.h<br>20 files changed, 0 insertions(+), 63 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/29853/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/amd/mahogany_fam10/romstage.c b/src/mainboard/amd/mahogany_fam10/romstage.c</span><br><span>index 39ff7a0..180fa5d 100644</span><br><span>--- a/src/mainboard/amd/mahogany_fam10/romstage.c</span><br><span>+++ b/src/mainboard/amd/mahogany_fam10/romstage.c</span><br><span>@@ -102,8 +102,6 @@</span><br><span> </span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/asus/m4a78-em/romstage.c b/src/mainboard/asus/m4a78-em/romstage.c</span><br><span>index 96d80cc..4860787 100644</span><br><span>--- a/src/mainboard/asus/m4a78-em/romstage.c</span><br><span>+++ b/src/mainboard/asus/m4a78-em/romstage.c</span><br><span>@@ -102,8 +102,6 @@</span><br><span> </span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/asus/m4a785-m/romstage.c b/src/mainboard/asus/m4a785-m/romstage.c</span><br><span>index 8eb9226..f8e2e32 100644</span><br><span>--- a/src/mainboard/asus/m4a785-m/romstage.c</span><br><span>+++ b/src/mainboard/asus/m4a785-m/romstage.c</span><br><span>@@ -103,8 +103,6 @@</span><br><span> </span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/asus/m5a88-v/romstage.c b/src/mainboard/asus/m5a88-v/romstage.c</span><br><span>index bb43dd5..9eec8c0 100644</span><br><span>--- a/src/mainboard/asus/m5a88-v/romstage.c</span><br><span>+++ b/src/mainboard/asus/m5a88-v/romstage.c</span><br><span>@@ -106,8 +106,6 @@</span><br><span> console_init();</span><br><span> printk(BIOS_DEBUG, "\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/gigabyte/ma785gm/romstage.c b/src/mainboard/gigabyte/ma785gm/romstage.c</span><br><span>index 098baac..9255b01 100644</span><br><span>--- a/src/mainboard/gigabyte/ma785gm/romstage.c</span><br><span>+++ b/src/mainboard/gigabyte/ma785gm/romstage.c</span><br><span>@@ -98,8 +98,6 @@</span><br><span> it8718f_disable_reboot(GPIO_DEV);</span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/gigabyte/ma785gmt/romstage.c b/src/mainboard/gigabyte/ma785gmt/romstage.c</span><br><span>index 05d2e04..cd7ff1e 100644</span><br><span>--- a/src/mainboard/gigabyte/ma785gmt/romstage.c</span><br><span>+++ b/src/mainboard/gigabyte/ma785gmt/romstage.c</span><br><span>@@ -98,8 +98,6 @@</span><br><span> it8718f_disable_reboot(GPIO_DEV);</span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/iei/kino-780am2-fam10/romstage.c b/src/mainboard/iei/kino-780am2-fam10/romstage.c</span><br><span>index fc1b32f..46da224 100644</span><br><span>--- a/src/mainboard/iei/kino-780am2-fam10/romstage.c</span><br><span>+++ b/src/mainboard/iei/kino-780am2-fam10/romstage.c</span><br><span>@@ -100,8 +100,6 @@</span><br><span> </span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/jetway/pa78vm5/romstage.c b/src/mainboard/jetway/pa78vm5/romstage.c</span><br><span>index f75c5a4..f738341 100644</span><br><span>--- a/src/mainboard/jetway/pa78vm5/romstage.c</span><br><span>+++ b/src/mainboard/jetway/pa78vm5/romstage.c</span><br><span>@@ -105,8 +105,6 @@</span><br><span> </span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/mainboard/supermicro/h8scm_fam10/romstage.c b/src/mainboard/supermicro/h8scm_fam10/romstage.c</span><br><span>index 3eeaeda..62f5f8d 100644</span><br><span>--- a/src/mainboard/supermicro/h8scm_fam10/romstage.c</span><br><span>+++ b/src/mainboard/supermicro/h8scm_fam10/romstage.c</span><br><span>@@ -112,8 +112,6 @@</span><br><span> </span><br><span> console_init();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Halt if there was a built in self test failure */</span><br><span> report_bist_failure(bist);</span><br><span> </span><br><span>diff --git a/src/northbridge/amd/amdfam10/debug.c b/src/northbridge/amd/amdfam10/debug.c</span><br><span>index 067c299..55a00e1 100644</span><br><span>--- a/src/northbridge/amd/amdfam10/debug.c</span><br><span>+++ b/src/northbridge/amd/amdfam10/debug.c</span><br><span>@@ -299,19 +299,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(u32 start, u32 end)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- u32 i;</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "dump_mem:");</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = start; i < end; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">- if ((i & 0xf) == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "\n%08x:", i);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "\n");</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #if IS_ENABLED(CONFIG_DIMM_DDR2)</span><br><span> void print_tx(const char *strval, u32 val)</span><br><span> {</span><br><span>diff --git a/src/northbridge/amd/amdfam10/debug.h b/src/northbridge/amd/amdfam10/debug.h</span><br><span>index a4ecfe9..a23303e 100644</span><br><span>--- a/src/northbridge/amd/amdfam10/debug.h</span><br><span>+++ b/src/northbridge/amd/amdfam10/debug.h</span><br><span>@@ -38,7 +38,6 @@</span><br><span> #endif</span><br><span> </span><br><span> void dump_io_resources(u32 port);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(u32 start, u32 end);</span><br><span> </span><br><span> void print_tx(const char *strval, u32 val);</span><br><span> void print_t(const char *strval);</span><br><span>diff --git a/src/northbridge/intel/e7505/debug.c b/src/northbridge/intel/e7505/debug.c</span><br><span>index f3a27e2..c21e321 100644</span><br><span>--- a/src/northbridge/intel/e7505/debug.c</span><br><span>+++ b/src/northbridge/intel/e7505/debug.c</span><br><span>@@ -183,15 +183,3 @@</span><br><span> port++;</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned start, unsigned end)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned i;</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "dump_mem:");</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = start; i < end; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">- if ((i & 0xf)==0)</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "\n%08x:", i);</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, " %02x", (unsigned char)*((unsigned char *)i));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "\n");</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/northbridge/intel/e7505/debug.h b/src/northbridge/intel/e7505/debug.h</span><br><span>index 238c500..98ca848 100644</span><br><span>--- a/src/northbridge/intel/e7505/debug.h</span><br><span>+++ b/src/northbridge/intel/e7505/debug.h</span><br><span>@@ -22,6 +22,5 @@</span><br><span> void dump_spd_registers(const struct mem_controller *ctrl);</span><br><span> void dump_smbus_registers(void);</span><br><span> void dump_io_resources(unsigned port);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned start, unsigned end);</span><br><span> </span><br><span> #endif</span><br><span>diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.h b/src/northbridge/intel/fsp_rangeley/northbridge.h</span><br><span>index f68d175..11089a5 100644</span><br><span>--- a/src/northbridge/intel/fsp_rangeley/northbridge.h</span><br><span>+++ b/src/northbridge/intel/fsp_rangeley/northbridge.h</span><br><span>@@ -69,7 +69,6 @@</span><br><span> void dump_pci_device(unsigned dev);</span><br><span> void dump_pci_devices(void);</span><br><span> void dump_spd_registers(void);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned start, unsigned end);</span><br><span> void report_platform_info(void);</span><br><span> </span><br><span> #ifndef __SIMPLE_DEVICE__</span><br><span>diff --git a/src/northbridge/intel/haswell/haswell.h b/src/northbridge/intel/haswell/haswell.h</span><br><span>index 33818ee..574a7f8 100644</span><br><span>--- a/src/northbridge/intel/haswell/haswell.h</span><br><span>+++ b/src/northbridge/intel/haswell/haswell.h</span><br><span>@@ -222,7 +222,6 @@</span><br><span> void dump_pci_device(unsigned dev);</span><br><span> void dump_pci_devices(void);</span><br><span> void dump_spd_registers(void);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned start, unsigned end);</span><br><span> void report_platform_info(void);</span><br><span> #endif /* !__SMM__ */</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/i945/debug.c b/src/northbridge/intel/i945/debug.c</span><br><span>index ef4f17b..c52f2a6 100644</span><br><span>--- a/src/northbridge/intel/i945/debug.c</span><br><span>+++ b/src/northbridge/intel/i945/debug.c</span><br><span>@@ -96,15 +96,3 @@</span><br><span> printk(BIOS_DEBUG, "\n");</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned int start, unsigned int end)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int i;</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "dump_mem:");</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = start; i < end; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">- if ((i & 0xf) == 0)</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "\n%08x:", i);</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, " %02x", (unsigned char)*((unsigned char *)i));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "\n");</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/northbridge/intel/i945/i945.h b/src/northbridge/intel/i945/i945.h</span><br><span>index 65a40e7..757eb52 100644</span><br><span>--- a/src/northbridge/intel/i945/i945.h</span><br><span>+++ b/src/northbridge/intel/i945/i945.h</span><br><span>@@ -379,7 +379,6 @@</span><br><span> void dump_pci_device(unsigned int dev);</span><br><span> void dump_pci_devices(void);</span><br><span> void dump_spd_registers(void);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned int start, unsigned int end);</span><br><span> </span><br><span> u32 decode_igd_memory_size(u32 gms);</span><br><span> u32 decode_tseg_size(const u8 esmramc);</span><br><span>diff --git a/src/northbridge/intel/nehalem/nehalem.h b/src/northbridge/intel/nehalem/nehalem.h</span><br><span>index 5756c90..b0e8490 100644</span><br><span>--- a/src/northbridge/intel/nehalem/nehalem.h</span><br><span>+++ b/src/northbridge/intel/nehalem/nehalem.h</span><br><span>@@ -277,7 +277,6 @@</span><br><span> void dump_pci_device(unsigned dev);</span><br><span> void dump_pci_devices(void);</span><br><span> void dump_spd_registers(void);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned start, unsigned end);</span><br><span> void report_platform_info(void);</span><br><span> #endif /* !__SMM__ */</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/sandybridge/sandybridge.h b/src/northbridge/intel/sandybridge/sandybridge.h</span><br><span>index faa9cd90..9e3da4b 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/sandybridge.h</span><br><span>+++ b/src/northbridge/intel/sandybridge/sandybridge.h</span><br><span>@@ -219,7 +219,6 @@</span><br><span> void dump_pci_device(unsigned dev);</span><br><span> void dump_pci_devices(void);</span><br><span> void dump_spd_registers(void);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned start, unsigned end);</span><br><span> </span><br><span> #endif /* !__SMM__ */</span><br><span> </span><br><span>diff --git a/src/soc/intel/fsp_baytrail/include/soc/baytrail.h b/src/soc/intel/fsp_baytrail/include/soc/baytrail.h</span><br><span>index 82fd0a1..68bdd12 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/include/soc/baytrail.h</span><br><span>+++ b/src/soc/intel/fsp_baytrail/include/soc/baytrail.h</span><br><span>@@ -63,7 +63,6 @@</span><br><span> void dump_pci_device(unsigned dev);</span><br><span> void dump_pci_devices(void);</span><br><span> void dump_spd_registers(void);</span><br><span style="color: hsl(0, 100%, 40%);">-void dump_mem(unsigned start, unsigned end);</span><br><span> void report_platform_info(void);</span><br><span> </span><br><span> #endif /* __PRE_RAM__ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29853">change 29853</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29853"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7f6431bb2903a0d06f8ed0ada93aa3231a58eb6f </div>
<div style="display:none"> Gerrit-Change-Number: 29853 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>