<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29860">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/amd/pi/00{630F01,730F01}: Use ARRAY_SIZE<br><br>Use already defined ARRAY_SIZE macro.<br><br>Change-Id: Ie22e3557e958b562816921a985411dd55c712142<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/northbridge/amd/pi/00630F01/dimmSpd.c<br>M src/northbridge/amd/pi/00730F01/dimmSpd.c<br>2 files changed, 6 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/29860/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/amd/pi/00630F01/dimmSpd.c b/src/northbridge/amd/pi/00630F01/dimmSpd.c</span><br><span>index 28e3fe4..dcf3192 100644</span><br><span>--- a/src/northbridge/amd/pi/00630F01/dimmSpd.c</span><br><span>+++ b/src/northbridge/amd/pi/00630F01/dimmSpd.c</span><br><span>@@ -23,8 +23,6 @@</span><br><span> </span><br><span> #include <northbridge/amd/pi/dimmSpd.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define DIMENSION(array)(sizeof(array)/ sizeof(array [0]))</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PARAMS *info)</span><br><span> {</span><br><span>     int spdAddress;</span><br><span>@@ -34,11 +32,11 @@</span><br><span>        if ((dev == 0) || (config == 0))</span><br><span>             return AGESA_ERROR;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (info->SocketId     >= DIMENSION(config->spdAddrLookup     ))</span><br><span style="color: hsl(120, 100%, 40%);">+     if (info->SocketId >= ARRAY_SIZE(config->spdAddrLookup))</span><br><span>            return AGESA_ERROR;</span><br><span style="color: hsl(0, 100%, 40%);">-     if (info->MemChannelId >= DIMENSION(config->spdAddrLookup[0]  ))</span><br><span style="color: hsl(120, 100%, 40%);">+     if (info->MemChannelId >= ARRAY_SIZE(config->spdAddrLookup[0]))</span><br><span>             return AGESA_ERROR;</span><br><span style="color: hsl(0, 100%, 40%);">-     if (info->DimmId       >= DIMENSION(config->spdAddrLookup[0][0]))</span><br><span style="color: hsl(120, 100%, 40%);">+    if (info->DimmId >= ARRAY_SIZE(config->spdAddrLookup[0][0]))</span><br><span>                return AGESA_ERROR;</span><br><span> </span><br><span>      spdAddress = config->spdAddrLookup</span><br><span>diff --git a/src/northbridge/amd/pi/00730F01/dimmSpd.c b/src/northbridge/amd/pi/00730F01/dimmSpd.c</span><br><span>index bbcbfe9..b7ffdb0 100644</span><br><span>--- a/src/northbridge/amd/pi/00730F01/dimmSpd.c</span><br><span>+++ b/src/northbridge/amd/pi/00730F01/dimmSpd.c</span><br><span>@@ -23,8 +23,6 @@</span><br><span> </span><br><span> #include <northbridge/amd/pi/dimmSpd.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define DIMENSION(array)(sizeof(array)/ sizeof(array [0]))</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PARAMS *info)</span><br><span> {</span><br><span>     int spdAddress;</span><br><span>@@ -34,11 +32,11 @@</span><br><span>        if ((dev == 0) || (config == 0))</span><br><span>             return AGESA_ERROR;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (info->SocketId     >= DIMENSION(config->spdAddrLookup      ))</span><br><span style="color: hsl(120, 100%, 40%);">+    if (info->SocketId >= ARRAY_SIZE(config->spdAddrLookup))</span><br><span>            return AGESA_ERROR;</span><br><span style="color: hsl(0, 100%, 40%);">-     if (info->MemChannelId >= DIMENSION(config->spdAddrLookup[0]   ))</span><br><span style="color: hsl(120, 100%, 40%);">+    if (info->MemChannelId >= ARRAY_SIZE(config->spdAddrLookup[0]))</span><br><span>             return AGESA_ERROR;</span><br><span style="color: hsl(0, 100%, 40%);">-     if (info->DimmId       >= DIMENSION(config->spdAddrLookup[0][0]))</span><br><span style="color: hsl(120, 100%, 40%);">+    if (info->DimmId >= ARRAY_SIZE(config->spdAddrLookup[0][0]))</span><br><span>                return AGESA_ERROR;</span><br><span> </span><br><span>      spdAddress = config->spdAddrLookup</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29860">change 29860</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29860"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie22e3557e958b562816921a985411dd55c712142 </div>
<div style="display:none"> Gerrit-Change-Number: 29860 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>