<p><a href="https://review.coreboot.org/c/coreboot/+/29768">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29768/1/src/mainboard/google/poppy/variants/nami/devicetree.cb">File src/mainboard/google/poppy/variants/nami/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29768/1/src/mainboard/google/poppy/variants/nami/devicetree.cb@350">Patch Set #1, Line 350:</a> <code style="font-family:monospace,monospace">H</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't think using '_' is valid. HID needs to be either uppercase letter (A-Z) or numeral (0-9).</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">After confirm with vendor, change GGT_7503 to GTCH7503.<br>Done</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29768">change 29768</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29768"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I26e16b7e118121b3dd9a88c76d04898b97753df0 </div>
<div style="display:none"> Gerrit-Change-Number: 29768 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Crystal Lin <crystal_lin@compal.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Crystal Lin <crystal_lin@compal.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Nov 2018 02:42:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>