<p>Philipp Deppenwiese has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29816">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/lenovo/t530: Improve configuration<br><br>* Enable vboot support with VBNV CMOS option.<br>* Add board and vboot-rw-ab fmds.<br>* Adjust CBFS sizes<br>* Increase thermal specs for performance version<br><br>Change-Id: I28c2fb92d574c8070dbf767adc5839faf4fb47a0<br>Signed-off-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com><br>---<br>M src/mainboard/lenovo/t530/Kconfig<br>A src/mainboard/lenovo/t530/board.fmd<br>M src/mainboard/lenovo/t530/cmos.layout<br>M src/mainboard/lenovo/t530/thermal.h<br>A src/mainboard/lenovo/t530/vboot-rw-ab.fmd<br>5 files changed, 83 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/29816/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig</span><br><span>index 61752d8..04f584c 100644</span><br><span>--- a/src/mainboard/lenovo/t530/Kconfig</span><br><span>+++ b/src/mainboard/lenovo/t530/Kconfig</span><br><span>@@ -28,6 +28,18 @@</span><br><span> </span><br><span> if BOARD_LENOVO_BASEBOARD_T530</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config VBOOT</span><br><span style="color: hsl(120, 100%, 40%);">+ select VBOOT_VBNV_CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ select VBOOT_NO_BOARD_SUPPORT</span><br><span style="color: hsl(120, 100%, 40%);">+ select GBB_FLAG_DISABLE_LID_SHUTDOWN</span><br><span style="color: hsl(120, 100%, 40%);">+ select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC</span><br><span style="color: hsl(120, 100%, 40%);">+ select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC</span><br><span style="color: hsl(120, 100%, 40%);">+ select GBB_FLAG_DISABLE_FWMP</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config VBOOT_VBNV_OFFSET</span><br><span style="color: hsl(120, 100%, 40%);">+ hex</span><br><span style="color: hsl(120, 100%, 40%);">+ default 0x2a</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> config VARIANT_DIR</span><br><span> string</span><br><span> default "t530" if BOARD_LENOVO_T530</span><br><span>@@ -75,4 +87,14 @@</span><br><span> bool</span><br><span> default y</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config FMDFILE</span><br><span style="color: hsl(120, 100%, 40%);">+ string</span><br><span style="color: hsl(120, 100%, 40%);">+ default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/vboot-rw-ab.fmd" if VBOOT</span><br><span style="color: hsl(120, 100%, 40%);">+ default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config CBFS_SIZE</span><br><span style="color: hsl(120, 100%, 40%);">+ hex</span><br><span style="color: hsl(120, 100%, 40%);">+ default 0x001d9000 if VBOOT</span><br><span style="color: hsl(120, 100%, 40%);">+ default 0x005ac000</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> endif</span><br><span>diff --git a/src/mainboard/lenovo/t530/board.fmd b/src/mainboard/lenovo/t530/board.fmd</span><br><span>new file mode 100644</span><br><span>index 0000000..74c0e15</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/lenovo/t530/board.fmd</span><br><span>@@ -0,0 +1,24 @@</span><br><span style="color: hsl(120, 100%, 40%);">+FLASH 12M {</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_ALL@0x0 0x500000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_DESC@0x0 0x1000</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_GBE@0x1000 0x2000</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_ME@0x3000 0x4fd000</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_BIOS@0x500000 0x700000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ MISC_RW@0x0 0x60000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_MRC_CACHE@0x0 0x10000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_VPD@0x010000 0x4000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x14000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ WP_RO@0x020000 0x6a0000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_VPD@0x0 0x4000</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_SECTION@0x4000 0x69c000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ FMAP@0x0 0x800</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_FRID@0x800 0x40</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_FRID_PAD@0x840 0x7c0</span><br><span style="color: hsl(120, 100%, 40%);">+ GBB@0x1000 0xef000</span><br><span style="color: hsl(120, 100%, 40%);">+ COREBOOT(CBFS)@0xf0000 0x5ac000</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/mainboard/lenovo/t530/cmos.layout b/src/mainboard/lenovo/t530/cmos.layout</span><br><span>index 3400a4d..aa91229 100644</span><br><span>--- a/src/mainboard/lenovo/t530/cmos.layout</span><br><span>+++ b/src/mainboard/lenovo/t530/cmos.layout</span><br><span>@@ -80,6 +80,7 @@</span><br><span> #437 3 r 0 unused</span><br><span> </span><br><span> 440 8 h 0 volume</span><br><span style="color: hsl(120, 100%, 40%);">+448 128 r 0 vbnv</span><br><span> </span><br><span> # SandyBridge MRC Scrambler Seed values</span><br><span> 896 32 r 0 mrc_scrambler_seed</span><br><span>diff --git a/src/mainboard/lenovo/t530/thermal.h b/src/mainboard/lenovo/t530/thermal.h</span><br><span>index 0b24ea8..06438e0 100644</span><br><span>--- a/src/mainboard/lenovo/t530/thermal.h</span><br><span>+++ b/src/mainboard/lenovo/t530/thermal.h</span><br><span>@@ -18,9 +18,9 @@</span><br><span> #define T530_THERMAL_H</span><br><span> </span><br><span> /* Temperature which OS will shutdown at */</span><br><span style="color: hsl(0, 100%, 40%);">- #define CRITICAL_TEMPERATURE 100</span><br><span style="color: hsl(120, 100%, 40%);">+ #define CRITICAL_TEMPERATURE 105</span><br><span> </span><br><span> /* Temperature which OS will throttle CPU */</span><br><span style="color: hsl(0, 100%, 40%);">- #define PASSIVE_TEMPERATURE 90</span><br><span style="color: hsl(120, 100%, 40%);">+ #define PASSIVE_TEMPERATURE 100</span><br><span> </span><br><span> #endif /* T530_THERMAL_H */</span><br><span>diff --git a/src/mainboard/lenovo/t530/vboot-rw-ab.fmd b/src/mainboard/lenovo/t530/vboot-rw-ab.fmd</span><br><span>new file mode 100644</span><br><span>index 0000000..f23e6b3</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/lenovo/t530/vboot-rw-ab.fmd</span><br><span>@@ -0,0 +1,34 @@</span><br><span style="color: hsl(120, 100%, 40%);">+FLASH 12M {</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_ALL@0x0 0x500000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_DESC@0x0 0x1000</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_GBE@0x1000 0x2000</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_ME@0x3000 0x4fd000</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ SI_BIOS@0x500000 0x700000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ MISC_RW@0x0 0x60000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_MRC_CACHE@0x0 0x10000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_VPD@0x010000 0x4000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x14000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ WP_RO@0x60000 0x2cd000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_VPD@0x0 0x4000</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_SECTION@0x4000 0x2c9000 {</span><br><span style="color: hsl(120, 100%, 40%);">+ FMAP@0x0 0x800</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_FRID@0x800 0x40</span><br><span style="color: hsl(120, 100%, 40%);">+ RO_FRID_PAD@0x840 0x7c0</span><br><span style="color: hsl(120, 100%, 40%);">+ GBB@0x1000 0xef000</span><br><span style="color: hsl(120, 100%, 40%);">+ COREBOOT(CBFS)@0xf0000 0x1d9000</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_SECTION_A@0x32d000 0x1e9040 {</span><br><span style="color: hsl(120, 100%, 40%);">+ VBLOCK_A@0x0 0x10000</span><br><span style="color: hsl(120, 100%, 40%);">+ FW_MAIN_A(CBFS)@0x10000 0x1d9000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_FWID_A@0x1e9000 0x40</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_SECTION_B@0x516040 0x1e9040 {</span><br><span style="color: hsl(120, 100%, 40%);">+ VBLOCK_B@0x0 0x10000</span><br><span style="color: hsl(120, 100%, 40%);">+ FW_MAIN_B(CBFS)@0x10000 0x1d9000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_FWID_B@0x1e9000 0x40</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29816">change 29816</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29816"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I28c2fb92d574c8070dbf767adc5839faf4fb47a0 </div>
<div style="display:none"> Gerrit-Change-Number: 29816 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>