<p><a href="https://review.coreboot.org/c/coreboot/+/29775">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c">File src/ec/google/chromeec/smihandler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c@102">Patch Set #1, Line 102:</a> <code style="font-family:monospace,monospace">#if IS_ENABLED(CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You will still have to populate 0 to SMI PORT in FADT to ensure OS doesn't expose that port. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">If CONFIG_REDUCED_SMI is enabled, https://review.coreboot.org/#/c/coreboot/+/28696/2/src/soc/intel/skylake/acpi.c will do populating the FADT right?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29775">change 29775</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29775"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I43ca93972fa4d870632707cb9a9e74ab80cbd5d5 </div>
<div style="display:none"> Gerrit-Change-Number: 29775 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jenny Tc <jenny.tc@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenny Tc <jenny.tc@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma@intel.com> </div>
<div style="display:none"> Gerrit-CC: Dhaval Sharma <dhaval.v.sharma@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 22 Nov 2018 07:05:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Dhaval Sharma <dhaval.v.sharma@intel.corp-partner.google.com> </div>
<div style="display:none"> Comment-In-Reply-To: Jenny Tc <jenny.tc@intel.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>