<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29784">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Update GPIO_178 in early_gpio_table in baseboard<br><br>This change updates the configuration of GPIO_178 to be active low as<br>per latest revision on different octopus variants. This effectively:<br>1. Gets rid of early_gpio_table in different variants -- phaser, meep,<br>fleex, bobba.<br>2. Deprecates board id < 2 for bobba, board id < 1 for fleex and<br>phaser.<br>3. Adds special early_gpio_table in yorp which has GPIO_178 as an<br>active high signal.<br><br>BUG=b:119885949<br><br>Change-Id: I024199a8f1f96db57f8fa60c4d265789cd3a0493<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/variants/baseboard/gpio.c<br>M src/mainboard/google/octopus/variants/bobba/gpio.c<br>M src/mainboard/google/octopus/variants/fleex/gpio.c<br>M src/mainboard/google/octopus/variants/meep/gpio.c<br>M src/mainboard/google/octopus/variants/phaser/gpio.c<br>A src/mainboard/google/octopus/variants/yorp/Makefile.inc<br>A src/mainboard/google/octopus/variants/yorp/gpio.c<br>7 files changed, 55 insertions(+), 172 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/29784/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>index 28dfaef..877cd76 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>@@ -308,7 +308,7 @@</span><br><span> PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1), /* H1_SLAVE_SPI_MOSI_R */</span><br><span> </span><br><span> /* Enable power to wifi early in bootblock and de-assert PERST#. */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPO(GPIO_178, 0, DEEP), /* EN_PP3300_WLAN_L */</span><br><span> PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */</span><br><span> </span><br><span> /*</span><br><span>diff --git a/src/mainboard/google/octopus/variants/bobba/gpio.c b/src/mainboard/google/octopus/variants/bobba/gpio.c</span><br><span>index 6b471e5..1b5c0bb 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/bobba/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/bobba/gpio.c</span><br><span>@@ -49,48 +49,3 @@</span><br><span> }</span><br><span> return c;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* GPIOs needed prior to ramstage. */</span><br><span style="color: hsl(0, 100%, 40%);">-static const struct pad_config early_gpio_table[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- /* PCH_WP_OD */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI(GPIO_190, NONE, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE,</span><br><span style="color: hsl(0, 100%, 40%);">- DISPUPD),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CLK_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_79, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CS_L_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_80, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MISO */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_82, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MOSI_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* WLAN_PE_RST */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPO(GPIO_164, 0, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak</span><br><span style="color: hsl(0, 100%, 40%);">- * pull-up for proper operation. Since there is no external pull present</span><br><span style="color: hsl(0, 100%, 40%);">- * on this platform, configure an internal weak pull-up.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,</span><br><span style="color: hsl(0, 100%, 40%);">- ENPU),</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-const struct pad_config *variant_early_gpio_table(size_t *num)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * This is a hack to configure EN_PP3300_WLAN based on board id. Once</span><br><span style="color: hsl(0, 100%, 40%);">- * board id 0/1 is deprecated, we can get rid of this.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- uint32_t bid = board_id();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (bid == UNDEFINED_STRAPPING_ID || bid < 2)</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_output(GPIO_178, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- else</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_output(GPIO_178, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- *num = ARRAY_SIZE(early_gpio_table);</span><br><span style="color: hsl(0, 100%, 40%);">- return early_gpio_table;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c</span><br><span>index ea7faf3..920d2c2 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/fleex/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/fleex/gpio.c</span><br><span>@@ -86,48 +86,3 @@</span><br><span> </span><br><span> return c;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* GPIOs needed prior to ramstage. */</span><br><span style="color: hsl(0, 100%, 40%);">-static const struct pad_config early_gpio_table[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- /* PCH_WP_OD */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI(GPIO_190, NONE, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE,</span><br><span style="color: hsl(0, 100%, 40%);">- DISPUPD),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CLK_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_79, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CS_L_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_80, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MISO */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_82, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MOSI_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* WLAN_PE_RST */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPO(GPIO_164, 0, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak</span><br><span style="color: hsl(0, 100%, 40%);">- * pull-up for proper operation. Since there is no external pull present</span><br><span style="color: hsl(0, 100%, 40%);">- * on this platform, configure an internal weak pull-up.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,</span><br><span style="color: hsl(0, 100%, 40%);">- ENPU),</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-const struct pad_config *variant_early_gpio_table(size_t *num)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * This is a hack to configure EN_PP3300_WLAN based on board id. Once</span><br><span style="color: hsl(0, 100%, 40%);">- * board id 0 is deprecated, we can get rid of this.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- uint32_t bid = board_id();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (bid == UNDEFINED_STRAPPING_ID || bid < 1)</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_output(GPIO_178, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- else</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_output(GPIO_178, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- *num = ARRAY_SIZE(early_gpio_table);</span><br><span style="color: hsl(0, 100%, 40%);">- return early_gpio_table;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/google/octopus/variants/meep/gpio.c b/src/mainboard/google/octopus/variants/meep/gpio.c</span><br><span>index 823224c..7e57287 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/meep/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/meep/gpio.c</span><br><span>@@ -38,39 +38,3 @@</span><br><span> *num = ARRAY_SIZE(default_override_table);</span><br><span> return default_override_table;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* GPIOs needed prior to ramstage. */</span><br><span style="color: hsl(0, 100%, 40%);">-static const struct pad_config early_gpio_table[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- /* PCH_WP_OD */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI(GPIO_190, NONE, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE,</span><br><span style="color: hsl(0, 100%, 40%);">- DISPUPD),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CLK_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_79, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CS_L_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_80, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MISO */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_82, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MOSI_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPO(GPIO_178, 0, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* WLAN_PE_RST */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPO(GPIO_164, 0, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak</span><br><span style="color: hsl(0, 100%, 40%);">- * pull-up for proper operation. Since there is no external pull present</span><br><span style="color: hsl(0, 100%, 40%);">- * on this platform, configure an internal weak pull-up.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,</span><br><span style="color: hsl(0, 100%, 40%);">- ENPU),</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-const struct pad_config *variant_early_gpio_table(size_t *num)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- *num = ARRAY_SIZE(early_gpio_table);</span><br><span style="color: hsl(0, 100%, 40%);">- return early_gpio_table;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/google/octopus/variants/phaser/gpio.c b/src/mainboard/google/octopus/variants/phaser/gpio.c</span><br><span>index 4d3210c..2a5dfbc 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/phaser/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/phaser/gpio.c</span><br><span>@@ -101,48 +101,3 @@</span><br><span> }</span><br><span> return c;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* GPIOs needed prior to ramstage. */</span><br><span style="color: hsl(0, 100%, 40%);">-static const struct pad_config early_gpio_table[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- /* PCH_WP_OD */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI(GPIO_190, NONE, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE,</span><br><span style="color: hsl(0, 100%, 40%);">- DISPUPD),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CLK_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_79, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_CS_L_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_80, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MISO */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_82, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">- /* H1_SLAVE_SPI_MOSI_R */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* WLAN_PE_RST */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPO(GPIO_164, 0, DEEP),</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak</span><br><span style="color: hsl(0, 100%, 40%);">- * pull-up for proper operation. Since there is no external pull present</span><br><span style="color: hsl(0, 100%, 40%);">- * on this platform, configure an internal weak pull-up.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,</span><br><span style="color: hsl(0, 100%, 40%);">- ENPU),</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-const struct pad_config *variant_early_gpio_table(size_t *num)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * This is a hack to configure EN_PP3300_WLAN based on board id. Once</span><br><span style="color: hsl(0, 100%, 40%);">- * board id 0 is deprecated, we can get rid of this.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- uint32_t bid = board_id();</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (bid == UNDEFINED_STRAPPING_ID || bid < 1)</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_output(GPIO_178, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- else</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_output(GPIO_178, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- *num = ARRAY_SIZE(early_gpio_table);</span><br><span style="color: hsl(0, 100%, 40%);">- return early_gpio_table;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/google/octopus/variants/yorp/Makefile.inc b/src/mainboard/google/octopus/variants/yorp/Makefile.inc</span><br><span>new file mode 100644</span><br><span>index 0000000..4b48156</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/yorp/Makefile.inc</span><br><span>@@ -0,0 +1 @@</span><br><span style="color: hsl(120, 100%, 40%);">+bootblock-y += gpio.c</span><br><span>diff --git a/src/mainboard/google/octopus/variants/yorp/gpio.c b/src/mainboard/google/octopus/variants/yorp/gpio.c</span><br><span>new file mode 100644</span><br><span>index 0000000..5719888</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/yorp/gpio.c</span><br><span>@@ -0,0 +1,53 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/variants.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <soc/gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* GPIOs needed prior to ramstage. */</span><br><span style="color: hsl(120, 100%, 40%);">+static const struct pad_config early_gpio_table[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPI(GPIO_190, NONE, DEEP), /* PCH_WP_OD */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* GSPI0_INT */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE,</span><br><span style="color: hsl(120, 100%, 40%);">+ DISPUPD), /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* GSPI0_CLK */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NF(GPIO_79, NONE, DEEP, NF1), /* H1_SLAVE_SPI_CLK_R */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* GSPI0_CS# */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NF(GPIO_80, NONE, DEEP, NF1), /* H1_SLAVE_SPI_CS_L_R */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* GSPI0_MISO */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NF(GPIO_82, NONE, DEEP, NF1), /* H1_SLAVE_SPI_MISO */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* GSPI0_MOSI */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1), /* H1_SLAVE_SPI_MOSI_R */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Enable power to wifi early in bootblock and de-assert PERST#. */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak</span><br><span style="color: hsl(120, 100%, 40%);">+ * pull-up for proper operation. Since there is no external pull present</span><br><span style="color: hsl(120, 100%, 40%);">+ * on this platform, configure an internal weak pull-up.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1,</span><br><span style="color: hsl(120, 100%, 40%);">+ ENPU), /* ESPI_IO1 */</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const struct pad_config *variant_early_gpio_table(size_t *num)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ *num = ARRAY_SIZE(early_gpio_table);</span><br><span style="color: hsl(120, 100%, 40%);">+ return early_gpio_table;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29784">change 29784</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29784"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I024199a8f1f96db57f8fa60c4d265789cd3a0493 </div>
<div style="display:none"> Gerrit-Change-Number: 29784 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>