<p>Nico Huber <strong>uploaded patch set #3</strong> to this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29684">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common: Bring DISPLAY_MTRRS into the light<br><br>Initially, I wanted to move only the Kconfig DISPLAY_MTRRS into the<br>"Debug" menu. It turned out, though, that the code looks rather generic<br>and while it's not perfect, I see nothing to be ashamed of. No need to<br>hide it in soc/intel/.<br><br>To not bloat src/Kconfig up any further, start a new `Kconfig.debug`<br>hierarchy just for debug options.<br><br>If somebody wants to review the code if it's 100% generic, we could<br>even get rid of HAVE_DISPLAY_MTRRS.<br><br>Change-Id: Ibd0a64121bd6e4ab5d7fd835f3ac25d3f5011f24<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M Documentation/Intel/Board/Galileo_checklist.html<br>M Documentation/Intel/SoC/soc.html<br>M src/Kconfig<br>M src/arch/x86/postcar.c<br>A src/cpu/Kconfig.debug<br>A src/cpu/x86/Kconfig.debug<br>M src/cpu/x86/mtrr/Makefile.inc<br>A src/cpu/x86/mtrr/debug.c<br>M src/cpu/x86/mtrr/earlymtrr.c<br>M src/drivers/intel/fsp1_1/after_raminit.S<br>M src/drivers/intel/fsp1_1/car.c<br>M src/drivers/intel/fsp1_1/include/fsp/ramstage.h<br>M src/drivers/intel/fsp1_1/include/fsp/romstage.h<br>M src/drivers/intel/fsp1_1/stack.c<br>M src/drivers/intel/fsp2_0/debug.c<br>M src/drivers/intel/fsp2_0/notify.c<br>M src/include/cpu/x86/mtrr.h<br>M src/soc/intel/common/Kconfig<br>M src/soc/intel/common/Makefile.inc<br>D src/soc/intel/common/util.c<br>D src/soc/intel/common/util.h<br>M src/soc/intel/quark/Makefile.inc<br>M src/soc/intel/quark/bootblock/bootblock.c<br>M src/soc/intel/quark/include/soc/ramstage.h<br>M src/soc/intel/quark/romstage/mtrr.c<br>M src/vendorcode/intel/fsp/fsp1_1/checklist/romstage_complete.dat<br>M src/vendorcode/intel/fsp/fsp1_1/checklist/romstage_optional.dat<br>M src/vendorcode/intel/fsp/fsp1_1/checklist/verstage_complete.dat<br>M src/vendorcode/intel/fsp/fsp1_1/checklist/verstage_optional.dat<br>29 files changed, 252 insertions(+), 313 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/29684/3</pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29684">change 29684</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29684"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibd0a64121bd6e4ab5d7fd835f3ac25d3f5011f24 </div>
<div style="display:none"> Gerrit-Change-Number: 29684 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>