<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29649">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Trent Begin: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/sarien: Set SMBIOS mainboard SKU<br><br>Setting sku_id() is not enough to get a value to show up in the SMBIOS<br>tables, it also needs to be returned as a string for the table creation<br>to consume.  This change defines the smbios_mainboard_sku() function<br>and returns a string constant of "sku#" as expected.<br><br>Change-Id: I03013bab89d53d1eba969c6ffb7e95fcbb315a81<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>Reviewed-on: https://review.coreboot.org/29649<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Reviewed-by: Trent Begin <tbegin@google.com><br>---<br>M src/mainboard/google/sarien/sku.c<br>M src/mainboard/google/sarien/variants/arcada/include/variant/variant.h<br>M src/mainboard/google/sarien/variants/sarien/include/variant/variant.h<br>3 files changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/sarien/sku.c b/src/mainboard/google/sarien/sku.c</span><br><span>index 9fc61a3..c064c02 100644</span><br><span>--- a/src/mainboard/google/sarien/sku.c</span><br><span>+++ b/src/mainboard/google/sarien/sku.c</span><br><span>@@ -14,9 +14,15 @@</span><br><span>  */</span><br><span> </span><br><span> #include <boardid.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <smbios.h></span><br><span> #include <variant/variant.h></span><br><span> </span><br><span> uint32_t sku_id(void)</span><br><span> {</span><br><span>      return VARIANT_SKU_ID;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const char *smbios_mainboard_sku(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+      return VARIANT_SKU_NAME;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h</span><br><span>index f1e551a..d128432 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h</span><br><span>+++ b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h</span><br><span>@@ -18,5 +18,6 @@</span><br><span> </span><br><span> /* Arcada is SKU ID 2 */</span><br><span> #define VARIANT_SKU_ID      2</span><br><span style="color: hsl(120, 100%, 40%);">+#define VARIANT_SKU_NAME "sku2"</span><br><span> </span><br><span> #endif</span><br><span>diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h</span><br><span>index d0be7fc..d367505 100644</span><br><span>--- a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h</span><br><span>+++ b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h</span><br><span>@@ -18,5 +18,6 @@</span><br><span> </span><br><span> /* Sarien is SKU ID 1 */</span><br><span> #define VARIANT_SKU_ID       1</span><br><span style="color: hsl(120, 100%, 40%);">+#define VARIANT_SKU_NAME "sku1"</span><br><span> </span><br><span> #endif</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29649">change 29649</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29649"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I03013bab89d53d1eba969c6ffb7e95fcbb315a81 </div>
<div style="display:none"> Gerrit-Change-Number: 29649 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Trent Begin <tbegin@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>