<p>Frans Hendriks has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29655">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/braswell: Disable the HPET<br><br>The timer interrupts don't appear when HPET is enabled. This<br>result in Linux reporting 'MP-BIOS bug: 8254 timer not connected<br>to IO-APIC'<br>Enabling CONFIG_DISABLE_HPET result into a booting system.<br><br>BUG=N/A<br>TEST=Portwell PQ7-M107<br><br>Change-Id: Ie9a78dcc736eb057c040a0a303c812adb1f76f3c<br>Signed-off-by: Frans Hendriks <fhendriks@eltan.com><br>---<br>M src/soc/intel/braswell/Kconfig<br>M src/soc/intel/braswell/acpi.c<br>M src/soc/intel/braswell/acpi/lpc.asl<br>3 files changed, 13 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/29655/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig</span><br><span>index 50c2802..c383cdf 100644</span><br><span>--- a/src/soc/intel/braswell/Kconfig</span><br><span>+++ b/src/soc/intel/braswell/Kconfig</span><br><span>@@ -128,4 +128,11 @@</span><br><span>       string</span><br><span>       default "soc/intel/braswell/bootblock/timestamp.inc"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config DISABLE_HPET</span><br><span style="color: hsl(120, 100%, 40%);">+       bool "Disable the HPET device"</span><br><span style="color: hsl(120, 100%, 40%);">+      default n</span><br><span style="color: hsl(120, 100%, 40%);">+     help</span><br><span style="color: hsl(120, 100%, 40%);">+   Enable this to disable the HPET support</span><br><span style="color: hsl(120, 100%, 40%);">+       Solves the Linux MP-BIOS bug timer not connected.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> endif</span><br><span>diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c</span><br><span>index f402f54..aa1cb74 100644</span><br><span>--- a/src/soc/intel/braswell/acpi.c</span><br><span>+++ b/src/soc/intel/braswell/acpi.c</span><br><span>@@ -4,6 +4,7 @@</span><br><span>  * Copyright (C) 2007-2009 coresystems GmbH</span><br><span>  * Copyright (C) 2013 Google Inc.</span><br><span>  * Copyright (C) 2015 Intel Corp.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Eltan B.V.</span><br><span>  *</span><br><span>  * This program is free software; you can redistribute it and/or modify</span><br><span>  * it under the terms of the GNU General Public License as published by</span><br><span>@@ -487,8 +488,10 @@</span><br><span>       acpi_header_t *ssdt2;</span><br><span>        global_nvs_t *gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        current = acpi_write_hpet(device, current, rsdp);</span><br><span style="color: hsl(0, 100%, 40%);">-       current = acpi_align_current(current);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (!IS_ENABLED(CONFIG_DISABLE_HPET)) {</span><br><span style="color: hsl(120, 100%, 40%);">+               current = acpi_write_hpet(device, current, rsdp);</span><br><span style="color: hsl(120, 100%, 40%);">+             current = acpi_align_current(current);</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span> </span><br><span>        if (IS_ENABLED(CONFIG_INTEL_GMA_ADD_VBT)) {</span><br><span>          igd_opregion_t *opregion;</span><br><span>diff --git a/src/soc/intel/braswell/acpi/lpc.asl b/src/soc/intel/braswell/acpi/lpc.asl</span><br><span>index 0a8b8bc..70486b1 100644</span><br><span>--- a/src/soc/intel/braswell/acpi/lpc.asl</span><br><span>+++ b/src/soc/intel/braswell/acpi/lpc.asl</span><br><span>@@ -3,6 +3,7 @@</span><br><span>  *</span><br><span>  * Copyright (C) 2007-2009 coresystems GmbH</span><br><span>  * Copyright (C) 2013 Google Inc.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Eltan B.V.</span><br><span>  *</span><br><span>  * This program is free software; you can redistribute it and/or</span><br><span>  * modify it under the terms of the GNU General Public License as</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29655">change 29655</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29655"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie9a78dcc736eb057c040a0a303c812adb1f76f3c </div>
<div style="display:none"> Gerrit-Change-Number: 29655 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>