<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29643">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check<br><br>soc_pch_pirq_init() function is only getting compiled for RAMSTAGE<br>hence remove unused __SIMPLE_DEVICE__ check.<br><br>Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/cannonlake/lpc.c<br>M src/soc/intel/icelake/lpc.c<br>2 files changed, 4 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29643/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c</span><br><span>index 84a2138..83d9cea 100644</span><br><span>--- a/src/soc/intel/cannonlake/lpc.c</span><br><span>+++ b/src/soc/intel/cannonlake/lpc.c</span><br><span>@@ -145,6 +145,7 @@</span><br><span> </span><br><span> void soc_pch_pirq_init(const struct device *dev)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+  struct device *irq_dev;</span><br><span>      const config_t *config = dev->chip_info;</span><br><span>  uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG];</span><br><span> </span><br><span>@@ -158,11 +159,7 @@</span><br><span>   pch_interrupt_routing[7] = config->pirqh_routing;</span><br><span> </span><br><span>     itss_irq_init(pch_interrupt_routing);</span><br><span style="color: hsl(0, 100%, 40%);">-#if defined(__SIMPLE_DEVICE__)</span><br><span style="color: hsl(0, 100%, 40%);">-     pci_devfn_t irq_dev;</span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(0, 100%, 40%);">-       struct device *irq_dev;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) {</span><br><span>           u8 int_pin = 0, int_line = 0;</span><br><span> </span><br><span>diff --git a/src/soc/intel/icelake/lpc.c b/src/soc/intel/icelake/lpc.c</span><br><span>index 8859c5d..63677c8 100644</span><br><span>--- a/src/soc/intel/icelake/lpc.c</span><br><span>+++ b/src/soc/intel/icelake/lpc.c</span><br><span>@@ -143,6 +143,7 @@</span><br><span> </span><br><span> void soc_pch_pirq_init(const struct device *dev)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *irq_dev;</span><br><span>      const config_t *config = dev->chip_info;</span><br><span>  uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG];</span><br><span> </span><br><span>@@ -156,11 +157,7 @@</span><br><span>   pch_interrupt_routing[7] = config->pirqh_routing;</span><br><span> </span><br><span>     itss_irq_init(pch_interrupt_routing);</span><br><span style="color: hsl(0, 100%, 40%);">-#if defined(__SIMPLE_DEVICE__)</span><br><span style="color: hsl(0, 100%, 40%);">-     pci_devfn_t irq_dev;</span><br><span style="color: hsl(0, 100%, 40%);">-#else</span><br><span style="color: hsl(0, 100%, 40%);">-       struct device *irq_dev;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) {</span><br><span>           u8 int_pin = 0, int_line = 0;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29643">change 29643</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29643"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 </div>
<div style="display:none"> Gerrit-Change-Number: 29643 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>