<p>Philipp Deppenwiese <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29601">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Stefan Reinauer: Looks good to me, approved
Philipp Deppenwiese: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/scripts/maintainers.go: Stub support for website tag<br><br>ME Cleaner's component has an entry specifying its website, which this<br>parser didn't know how to handle. Avoid the resulting warning.<br><br>While at it, de-C the switch statement and make it work go-style. This<br>also fixes "R" statements being ignored.<br><br>Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21<br>Signed-off-by: Patrick Georgi <pgeorgi@google.com><br>Reviewed-on: https://review.coreboot.org/29601<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org><br>Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com><br>---<br>M util/scripts/maintainers.go<br>1 file changed, 7 insertions(+), 32 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go</span><br><span>index 03c7709..a457581 100644</span><br><span>--- a/util/scripts/maintainers.go</span><br><span>+++ b/util/scripts/maintainers.go</span><br><span>@@ -95,40 +95,15 @@</span><br><span> current.name = line</span><br><span> } else {</span><br><span> switch line[0] {</span><br><span style="color: hsl(0, 100%, 40%);">- case 'R':</span><br><span style="color: hsl(0, 100%, 40%);">- case 'M':</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- /* Add subsystem maintainer */</span><br><span style="color: hsl(0, 100%, 40%);">- current.maintainer =</span><br><span style="color: hsl(0, 100%, 40%);">- append(current.maintainer,</span><br><span style="color: hsl(0, 100%, 40%);">- line[3:len(line)])</span><br><span style="color: hsl(0, 100%, 40%);">- break</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- case 'S':</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- break</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- case 'L':</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- break</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- case 'T':</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- break</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ case 'R', 'M':</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Add subsystem maintainer */</span><br><span style="color: hsl(120, 100%, 40%);">+ current.maintainer = append(current.maintainer, line[3:len(line)])</span><br><span> case 'F':</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- // add files</span><br><span style="color: hsl(0, 100%, 40%);">- current.file =</span><br><span style="color: hsl(0, 100%, 40%);">- append(current.file,</span><br><span style="color: hsl(0, 100%, 40%);">- line[3:len(line)])</span><br><span style="color: hsl(0, 100%, 40%);">- break</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ // add files</span><br><span style="color: hsl(120, 100%, 40%);">+ current.file = append(current.file, line[3:len(line)])</span><br><span style="color: hsl(120, 100%, 40%);">+ case 'L', 'S', 'T', 'W': // ignore</span><br><span> default:</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- fmt.Println("No such specifier: ", line)</span><br><span style="color: hsl(0, 100%, 40%);">- break</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ fmt.Println("No such specifier: ", line)</span><br><span> }</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29601">change 29601</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29601"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21 </div>
<div style="display:none"> Gerrit-Change-Number: 29601 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Ronald G. Minnich <rminnich@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Ronald Minnich <rminnich@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>